Drop is moving, let's keep the issue open until d8 release

RC1 is out so next step is building release

CommentFileSizeAuthor
#15 test-results.png32.83 KBchi
#9 1.patch27.49 KBandypost
#3 2573203-double_field-3.patch4.03 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented

SafeMarkup is changing https://github.com/andypost/double_field/commit/6fe5f16a49cf8267b1a0ced1...
Looks we need to clean-up formatter summary to get rid of HTML tags

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 2573203-double_field-3.patch4.03 KB

the patch

gumanist’s picture

gumanist commented
Status: Needs review » Reviewed & tested by the community

Tested and its working fine.

  • Chi committed 066272b on 8.x-3.x 
    Issue #2573203 by andypost: Update codebase for current D8 state
  • Chi committed a89f9a9 on 8.x-3.x authored by andypost
    Issue #2573203 by andypost: Update codebase for current D8 state
chi’s picture

chi commented
Status: Reviewed & tested by the community » Needs work

Commited. Thanks.

However since SafeMarkkup is marked as deprecated.
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Util...
It needs a bit more investigation.

andypost’s picture

andypost
he/him
Primary language Russian
commented

yep, and plugin interfaces changed

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new 1.patch27.49 KB

pushed one more commit, module needs to clean-up a lot commented-out code

andypost’s picture

andypost
he/him
Primary language Russian
commented

maybe module needs novice issue to make module pass coder review

  • Chi committed 59d33e7 on 8.x-3.x authored by andypost 
    Issue #2573203 by andypost: Update codebase for current D8 state
chi’s picture

chi commented

I just fixed most of the code style issues. I will do a final cleanup later just before the module gets some stable release.

chi’s picture

chi commented
Status: Needs review » Fixed

Drupal core RC is out so API changes are not expected any longer. I have just released the first beta version of the module. Thanks for the help.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Thanx for quick response! Other issues should be filed separate. Also would be great to add test coverage especially for render caching

chi’s picture

chi commented
StatusFileSize
new test-results.png32.83 KB

Test coverage is already done.
Test results

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.