A lot of people are using drush to deploy and update their websites. With gmap_regenerate_markers() locked in cli mode without any commented reason, some updates are failing without any warning and it's really hard to find out why. The result is that the gmap_markers.js file is not created so all the maps that uses custom markers are appearing empty.
Unlock that function as it contains absolutely nothing that is likely to fail specifically in cli mode.
| Task | Novice task? | Contributor instructions | Complete? |
|---|---|---|---|
| Create a patch | Instructions | Done in #1 | |
| Manually test the patch | Novice | Instructions | |
| Add steps to reproduce the issue | Novice | Instructions | Done in #1 |
| Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions |
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | gmap-unlock_gmap_generate_markers-2571855-1.patch | 390 bytes | duaelfr |
Comments
Comment #2
duaelfrComment #3
podarokThat was made due to issues in the past.
I believe all those issues were fixed, so merging.
Thanks for pushing this up.