Fix Scald render cache when used with an array of options

Hi, thanks for the patch!

I think we should also check if its a string or not after checking if its an array, so if its a string we can md5 there as well, and if its not a string then we would add the value unaltered. Though most of the cases it will be a string i think.

So something like

    if (is_array($options)) {
      $cache_parts[] = md5(drupal_json_encode($options));
    }
    else if (is_string($options)) {
      $cache_parts[] = md5($options);
    }
    else {
      $cache_parts[] = $options;
    }

So then in case of giving a string value, it will always have md5 result at the end.

because of comment #5

Actually there are bigger problems here, since if I give it an array like
scald_render(200,'sdl_editor_representation', array('link' => 'test'));

Then it will give me an error:
Warning: json_decode() expects parameter 1 to be string, array given in drupal_json_decode() (line 5111 of includes/common.inc).

So the problem is that if its an array then the following line fails:

  // If $options is not a JSON string or a single value, give other modules a
  // chance to handle it.
  if ($options) {
    if (!is_array($decoded = drupal_json_decode($options))) {

So maybe the best is to always convert to json if its an array at the very beginning of the render function.

@jcisio what do you think?

Fix for #7

Thanks, but it does not include 5

#8 does not include the fix you suggested in #5, but it does fix the issue you mentioned.
It just skips the useless decode step of an array $options, which is passed unchanged to following steps.
At least it works for me; did you try it ?

No it does not fix it...

As you can see the string is md5 coded in the patch... now if you just input a json encoded string, then it wont be md5 coded, and therefore two identical options array will be considered as different.

So something like this.

Thanks, Committed.