...or something. ;)

Basically, in BlockRegion process plugin, if the source and destination theme are the same, it assumes they have the same regions.

So if you place a block into "Triptych Middle," which is dropped from D8, the block will not be dropped in the Content region as you'd expect, but instead will come over as an un-placed block, and you'll lose your placement/visibility settings.

This error affects both D6 and D7 migrations since they both use the same plugin.

CommentFileSizeAuthor
#20 2569703-20.patch7.48 KBphenaproxima
#18 2569703-18.patch7.45 KBphenaproxima
#14 2569703-14.patch7.43 KBphenaproxima
#8 2569703-8.patch6.04 KBphenaproxima
#5 2569703-5.patch5.23 KBphenaproxima
#2 2569703-2.patch5.27 KBphenaproxima

Comments

webchick created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 2569703-2.patch5.27 KB

Fixed, with tests.

Status: Needs review » Needs work

The last submitted patch, 2: 2569703-2.patch, failed testing.

The last submitted patch, 2: 2569703-2.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2569703-5.patch5.23 KB

Maybe that should be a smidge more resistant to InvalidArgumentExceptions.

Status: Needs review » Needs work

The last submitted patch, 5: 2569703-5.patch, failed testing.

The last submitted patch, 5: 2569703-5.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2569703-8.patch6.04 KB

It even comes in T-shirt form. http://www.amazon.com/Peanuts-Mens-T-Shirt-Classic-Football/dp/B00KNBEWUU

Status: Needs review » Needs work

The last submitted patch, 8: 2569703-8.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

Uh...riiight. DrupalCI didn't seem to have a problem with it. QA, why can't you be more like your younger brother?

Status: Needs work » Needs review

phenaproxima queued 8: 2569703-8.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 8: 2569703-8.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: +Needs reroll

Sigh.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2569703-14.patch7.43 KB

Okay, that was a pretty excruciating re-roll. Please, patch, I beg you: pass the damn tests.

Status: Needs review » Needs work

The last submitted patch, 14: 2569703-14.patch, failed testing.

Status: Needs work » Needs review

phenaproxima queued 14: 2569703-14.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 14: 2569703-14.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2569703-18.patch7.45 KB

Namespace fix. I hate this patch.

benjy’s picture

benjy commented

Looking good, just some missing docs.

  1. +++ b/core/modules/block/src/Plugin/migrate/process/BlockRegion.php
@@ -7,30 +7,65 @@
+  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {

    Missing docs. 

  2. +++ b/core/modules/block/src/Tests/Migrate/d7/MigrateBlockTest.php
@@ -23,7 +23,7 @@ class MigrateBlockTest extends MigrateDrupal7TestBase {
    */
-  static $modules = array(
+  static $modules = [

@@ -33,7 +33,7 @@ class MigrateBlockTest extends MigrateDrupal7TestBase {
-  );
+  ];

    He's back

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2569703-20.patch7.48 KB
  1. Fixed.
  2. Now you see him, now you don't!
benjy’s picture

benjy commented
Status: Needs review » Reviewed & tested by the community

Great!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 1a1b6b5 and pushed to 8.0.x. Thanks!

  • alexpott committed 1a1b6b5 on 8.0.x 
    Issue #2569703 by phenaproxima, benjy, webchick: When migrating to the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 20: 2569703-20.patch, failed testing.

  • alexpott committed 1a1b6b5 on 8.1.x 
    Issue #2569703 by phenaproxima, benjy, webchick: When migrating to the...

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs work » Fixed

Testbot late to the party reset the status...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.