Add admin-setting to disable calls to hook_user_logout [#2568789]

We're using the masquerade-module in an environment with SSO/Shibboleth. Those modules (and other SSO-implementations I guess) are using hook_user_logout to redirect the user to a certain logout-page to disable the SSO-session.

In this setup you have to re-login every time you try to switch the user, which is... annoying.

To solve this I've added a configuration option to disable the call of hook_user_logout.

Comment	File	Size	Author
#2	masquerade-disable_hook_user_logout-2568789-1-D7.patch	1.51 KB	phreaknerd

Comments

Comment #1

15 September 2015 at 12:18

phreaknerd created an issue. See original summary.

Comment #2

phreaknerd commented 15 September 2015 at 12:23

Status	File	Size
new	masquerade-disable_hook_user_logout-2568789-1-D7.patch	1.51 KB

The patch.

Comment #3

phreaknerd commented 25 September 2015 at 10:07

Category:	Feature request	» Bug report
Status:	Active	» Needs review

Comment #4

andypost

he/him

Russian

commented 25 September 2015 at 10:48

The primary idea of the module that we do full logout/login to masquerade
if you skip any of hooks - it's not a logout anymore

+1 to wont fix

+++ b/masquerade.module
@@ -844,7 +851,7 @@ function masquerade_switch_user($uid) {
-  module_invoke_all('user_logout', $user);
+  if(!variable_get('masquerade_disable_logout_hooks', 0)) module_invoke_all('user_logout', $user);

this will not work