Follow-up to #2562849: [meta] Confirmation page

Just so we have a UI to review, we're hard-coding the relationships between individual migrations and the source- and destination-side modules they involve. This is not sustainable - we need a way to discover those relationships automatically. That will certainly require a core-side patch to provide the necessary information - once that's in, we can replace the giant array with nice clean code.

CommentFileSizeAuthor
#2 standardize_source-2568523-2.patch15.76 KBmikeryan
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

mikeryan created an issue. See original summary.

mikeryan’s picture

Here's a patch which works with the core patch at https://www.drupal.org/node/2569805#comment-10355185.

mikeryan’s picture

Issue tags: +Barcelona2015

Tagged for review at Barcelona sprints.

benjy’s picture

In general I think this looks good, i'll review the new keys in core independently.

+++ b/src/Form/MigrateUpgradeForm.php
@@ -742,12 +245,20 @@ class MigrateUpgradeForm extends FormBase implements ConfirmFormInterface {
+      if (isset($source['provider']) && $destination['provider']) {
+        $source_module = $source['provider'];
+        $destination_module = $destination['provider'];
...
+      else {
+        $source_module = $this->t('Unknown');
+        $destination_module = $this->t('Unknown');

If you have a source provider but not a destination provider, you'll still end up with Unknown for both.

mikeryan’s picture

Project: Migrate Upgrade » Drupal core
Version: 8.x-1.x-dev » 8.1.x-dev
Component: User interface » migration system
Issue tags: -Barcelona2015

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mikeryan’s picture