The custom block type edit form page currently has a title of "Edit". Attached patch changes it to include the type name, so e.g. "Edit My Image Block custom block type". This gives important context to the page, especially because the page has no tabs that would tell anything about the context.

API changes

None, pure UI change.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because UX improvment
Issue priority Normal because nicety
Unfrozen changes Unfrozen because it only changes strings
Prioritized changes The main goal of this issue is usability
Disruption None
CommentFileSizeAuthor
#6 type-name-header-2567115.3.patch2.15 KBlarowlan
#6 interdiff.txt766 byteslarowlan
#4 type-name-header-2567115.test.patch2.12 KBlarowlan
#4 interdiff.txt817 byteslarowlan
block_type_form_title.patch1.32 KBFrando

Comments

Frando created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Can you add an assert to an existing test covering this.
We also need a beta summary

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue summary: View changes
Issue tags: +Needs tests

Added beta eval

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: -Needs tests
StatusFileSize
new interdiff.txt817 bytes
new type-name-header-2567115.test.patch2.12 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented 
+++ b/core/modules/block_content/src/Tests/BlockContentTypeTest.php
@@ -110,7 +110,9 @@ public function testBlockContentTypeEditing() {
+    $this->assertTitle('Edit basic custom block type | Drupal');

maybe better to use format_string() here?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new interdiff.txt766 bytes
new type-name-header-2567115.3.patch2.15 KB

Sure

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

looks good

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: type-name-header-2567115.3.patch, failed testing.

Status: Needs work » Needs review

andypost queued 6: type-name-header-2567115.3.patch for re-testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: type-name-header-2567115.3.patch, failed testing.

Status: Needs work » Needs review

larowlan queued 6: type-name-header-2567115.3.patch for re-testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

random fail

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +Usability

This is a usability improvement and therefore should be permitted during beta. Committed b8db52f and pushed to 8.0.x. Thanks!

  • alexpott committed b8db52f on 8.0.x 
    Issue #2567115 by larowlan, Frando: Show type name in custom block type...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.