See: #2489460: [Meta] Move module.theme.css files to Classy or Seven
Move the CSS files to classy
Rename the files to remove the .theme. extension
Alter the drupal.dropbutton library so the CSS files are loaded with a similar weight to before
Check that the CSS file was deleted from the module and added to Classy
Check that the references to that CSS file removed from the system module
Check that the CSS file is being loaded in the correct places in Classy
Check that there are no HTML classes in the module that relies on the theme CSS
None for Classy, Stark will be more Stark
None
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | Screenshot 2015-09-13 22.26.57.jpg | 333.28 KB | lewisnyman |
| #4 | Screenshot 2015-09-13 22.14.30.jpg | 323.72 KB | lewisnyman |
| #4 | Screenshot 2015-09-13 22.15.02.jpg | 301.24 KB | lewisnyman |
| #4 | move-2566823-4.patch | 1.79 KB | lewisnyman |
Comments
Comment #2
lewisnymanComment #3
rainbowarrayDropbutton is used by Quick Edit, so should maybe go in Seven with the funky stuff so that it works on the front-end even on non-Classy themes.
Comment #4
lewisnymanHere's the patch and some screenshots in Stark, Classy, and Seven.
Stark
Classy
Seven
Comment #5
gints.erglis commentedhttps://www.drupal.org/node/2489564 - if this is applied before this patch, then conflicting, because the file /core/themes/classy/classy.theme is created already. But this is not an issue in this case.
Comment #6
lewisnymanThanks. Postponing based on: #2566771: [Voltron patch] Move all remaining *.theme.css to Classy Getting there!
Comment #7
rainbowarrayAfter seeing the screenshots, it's clear that Classy's dropbutton already looked more unstyled than Bartik for example. So moving those styles to Classy just leaves core looking more unstyled. So it goes.
Long term I'd love for the admin theme to be able to style front-end admin components like dropbutton, but that's a challenge for another day.
Comment #8
akalata commented