Reviewed & tested by the community
Project:
Phone
Version:
7.x-1.0-beta1
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Sep 2015 at 09:07 UTC
Updated:
15 May 2016 at 22:06 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tusharbodke commentedHi,
Please find patch where requested mobile number is added for 073 (Life) to file phone.ua.inc.
Thanks
Comment #3
tusharbodke commentedComment #4
tusharbodke commentedHi cweagans ,
Can you please have a look and confirm submitted patch?
Looking forward to hearing from your end.
Comment #5
gaurav.bajpai commentedHi Tushar,
Applied your patch and found code 073 (Life) added to file in phone.ua.inc $mobiles
Thanks!!
Comment #6
dpovshed commentedThe patch is not working for me.
Reasons:
1) patch should not contain any supplementary info like
From: ...
Date: ...
Subject: ...
2) Ukrainian Life operator code should be 73 but not the 073 like you added into the patch. Country code is +380, so adding zero is erroneous.
Please correct.
Comment #7
hamrant commentedComment #8
dpovshed commentedThis one looks much healthier, I am vote for RTBC.
Also probably makes sense to review all UA mobile operators and add more codes if needed, if you have time.
Comment #9
dpovshed commentedComment #10
hamrant commentedWhen you consider this patch, all mobile operators are already included in the list.
- MTS-UKR +38050, +38066, +38095, +38099
- Kyivstar +38067, +38096, +38097, +38098
- Life:) +38063, +38073, +38093
- Beeline +38068
- Peoplenet (CDMA/3g) +38092
- UTEL (3g) +38091
- Intertelecom (CDMA/3g) +38094
- Golden Telecom +38039
Comment #11
dpovshed commentedGreat, then we need maintainer's attention to commit this!
Comment #12
pifagor commentedComment #13
dpovshed commented@pifagor, what is the reason of closing this issue?
Comment #14
pifagor commentedThe problem was solved patch
Comment #15
dpovshed commentedSure, the patch from comment #7 successfully addressing request from issue description.
But lets keep the issue active until the patch integrated (committed) into main branch by maintainer.