Add code 073 (Life) to file in alternating phone.ua.inc $mobiles

CommentFileSizeAuthor
#7 phone-new-monile-code-2566149-7.patch275 byteshamrant
#3 phone-new-monile-code-2566149-1.patch578 bytestusharbodke
#2 phone-new-monile-code-2566149-1.patch274 bytestusharbodke
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pifagor87 created an issue. See original summary.

tusharbodke’s picture

tusharbodke CreditAttribution: tusharbodke as a volunteer and at Faichi Solutions Pvt Ltd commented
Status: Needs work » Needs review
FileSize
phone-new-monile-code-2566149-1.patch274 bytes

Hi,
Please find patch where requested mobile number is added for 073 (Life) to file phone.ua.inc.

Thanks

tusharbodke’s picture

tusharbodke CreditAttribution: tusharbodke as a volunteer and at Faichi Solutions Pvt Ltd commented
FileSize
phone-new-monile-code-2566149-1.patch578 bytes
tusharbodke’s picture

tusharbodke CreditAttribution: tusharbodke as a volunteer and at Faichi Solutions Pvt Ltd commented

Hi cweagans ,
Can you please have a look and confirm submitted patch?
Looking forward to hearing from your end.

gaurav.bajpai’s picture

gaurav.bajpai CreditAttribution: gaurav.bajpai as a volunteer and at Faichi Solutions Pvt Ltd commented
Status: Needs review » Reviewed & tested by the community

Hi Tushar,

Applied your patch and found code 073 (Life) added to file in phone.ua.inc $mobiles

Thanks!!

dpovshed’s picture

dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commented
Status: Reviewed & tested by the community » Needs work

The patch is not working for me.

Reasons:
1) patch should not contain any supplementary info like
From: ...
Date: ...
Subject: ...

2) Ukrainian Life operator code should be 73 but not the 073 like you added into the patch. Country code is +380, so adding zero is erroneous.

Please correct.

hamrant’s picture

hamrant CreditAttribution: hamrant at DEWEB Studio for Drupal Ukraine Community commented
Status: Needs work » Needs review
FileSize
phone-new-monile-code-2566149-7.patch275 bytes
dpovshed’s picture

dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commented

This one looks much healthier, I am vote for RTBC.

Also probably makes sense to review all UA mobile operators and add more codes if needed, if you have time.

dpovshed’s picture

dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commented
Status: Needs review » Reviewed & tested by the community
hamrant’s picture

hamrant CreditAttribution: hamrant at DEWEB Studio for Drupal Ukraine Community commented

When you consider this patch, all mobile operators are already included in the list.
- MTS-UKR +38050, +38066, +38095, +38099
- Kyivstar +38067, +38096, +38097, +38098
- Life:) +38063, +38073, +38093
- Beeline +38068
- Peoplenet (CDMA/3g) +38092
- UTEL (3g) +38091
- Intertelecom (CDMA/3g) +38094
- Golden Telecom +38039

dpovshed’s picture

dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commented

Great, then we need maintainer's attention to commit this!

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor commented
Status: Reviewed & tested by the community » Closed (fixed)
dpovshed’s picture

dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commented

@pifagor, what is the reason of closing this issue?

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor commented

The problem was solved patch

dpovshed’s picture

dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commented
Status: Closed (fixed) » Reviewed & tested by the community

Sure, the patch from comment #7 successfully addressing request from issue description.

But lets keep the issue active until the patch integrated (committed) into main branch by maintainer.