Hi Folks,

Since Firefox and Chrome now have Flash disabled by default, and since all modern browsers can render HTML5, I think it's probably time to move Scald Audio to HTML5.

I'm including a small patch here that rewrites the scald_audio_player.tpl.php file to do this.

Thanks.

CommentFileSizeAuthor
#15 scald-use-html5-for-scald-audio-2565655-15.patch2.05 KBgifad
#10 scald-use-html5-for-scald-audio-2565655-10.patch2.64 KBgifad
#3 scald-use-html5-for-scald-audio-2565655-1-7.x.patch1.17 KBmarkconroy
#2 scald-using-html5.png25.04 KBmarkconroy
#2 scald-using-flash.png19.33 KBmarkconroy

Comments

markconroy created an issue. See original summary.

markconroy’s picture

markconroy commented
StatusFileSize
new scald-using-flash.png19.33 KB
new scald-using-html5.png25.04 KB
markconroy’s picture

markconroy commented
Status: Active » Needs review
StatusFileSize
new scald-use-html5-for-scald-audio-2565655-1-7.x.patch1.17 KB

Attaching the patch for this.

Status: Needs review » Needs work

The last submitted patch, 3: scald-use-html5-for-scald-audio-2565655-1-7.x.patch, failed testing.

Status: Needs work » Needs review

markconroy queued 3: scald-use-html5-for-scald-audio-2565655-1-7.x.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: scald-use-html5-for-scald-audio-2565655-1-7.x.patch, failed testing.

nagy.balint’s picture

nagy.balint commented
Version: 7.x-1.4 » 7.x-1.x-dev
Status: Needs work » Needs review
nagy.balint’s picture

nagy.balint commented

Its a good idea yes, seeing as we are not officially supporting IE 8 anymore anyways, then all the browsers we support have the audio tag capability.

nagy.balint queued 3: scald-use-html5-for-scald-audio-2565655-1-7.x.patch for re-testing.

gifad’s picture

gifad commented
StatusFileSize
new scald-use-html5-for-scald-audio-2565655-10.patch2.64 KB

It's of course good to have an html5 player for scald audio, but implementing it as the default player has the unpleasant side effect to break some pages layout on existing sites... (plus, the size of the control is browser dependant);
So I reworked it as a scald player...

nagy.balint’s picture

nagy.balint commented

@gifad:
Thanks for the patch!

Cant we use a separate template file for the html5 player?

markconroy’s picture

markconroy commented

Folks,

If we take this approach, we can also remove the flash folders from the audio module. And if we wanted to take it one step further, I'd suggest using jPlayer https://www.drupal.org/project/jplayer instead of just so the player is themable.

nagy.balint’s picture

nagy.balint commented

If we keep the original flash player, and just implement a html5 player then the folders are still required.

nagy.balint’s picture

nagy.balint commented
Status: Needs review » Needs work

Because of comment #11

gifad’s picture

gifad commented
Status: Needs work » Needs review
StatusFileSize
new scald-use-html5-for-scald-audio-2565655-15.patch2.05 KB

Cant we use a separate template file for the html5 player?

Yes we can ;-)

nagy.balint’s picture

nagy.balint commented
Status: Needs review » Fixed

Seems fine, committed.

Thanks!

  • nagy.balint committed 1013843 on 7.x-1.x authored by gifad 
    Issue #2565655 by gifad, markconroy: Add HTML5 player to Play Audio...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.