Hi,

Do you plan to make a version of the module for D8?

I'd like to help you in the development and implementation of module for D8 from scratch.

Thanks,
Madan Gopal

CommentFileSizeAuthor
#8 age_calculator_drupal_8_version.patch41.54 KBnehajyoti
#2 age_calculator.zip8.45 KBmadan879
age_calculator.zip9.18 KBmadan879

Comments

madan879 created an issue. See original summary.

madan879’s picture

madan879 commented
StatusFileSize
new age_calculator.zip8.45 KB
madan879’s picture

madan879 commented

Hello,

Please kindly review and update me ASAP..

kunalkursija’s picture

kunalkursija commented

Hi Madan,

Have been quite busy with other things. Will be reviewing this ASAP & update.

Thanks for your help Madan.

madan879’s picture

madan879 commented

Hello Kunal, Any updates....

kunalkursija’s picture

kunalkursija commented
Status: Needs review » Needs work

Hi Madan,

I tried the module and couldn't find any blocks for age calculator.

Also there are lots of issues as per coding standards.

You can use http://pareview.sh/ to fix some of issues.

madan879’s picture

madan879 commented

Hello Kunal,

Based on your valuable instruction for fixing the coding standards, I have followed and fixed issue. So please check sandbox for below link:

https://www.drupal.org/sandbox/madan879/2694019

And you can download latest files from version control..

And I have checked in pareview.sh website too, for reference below link:

http://pareview.sh/pareview/httpgitdrupalorgsandboxmadan8792694019git

Then, once you enabled module you have set permission for this module after clear cache. I also checked its showing and working fine for me.. Please kindly try it once again....

nehajyoti’s picture

nehajyoti commented
StatusFileSize
new age_calculator_drupal_8_version.patch41.54 KB
nehajyoti’s picture

nehajyoti commented
Assigned: Unassigned » nehajyoti
Category: Feature request » Task
Status: Needs work » Needs review

Please review https://www.drupal.org/node/2565609#comment-11566165 patch for D8 version uploaded.

kunalkursija’s picture

kunalkursija commented
Assigned: nehajyoti » kunalkursija
kunalkursija’s picture

kunalkursija commented

Hi Guys,

I have reviewed @madan's code & jyoti's code too. There were few issues in both, i am working on fixing the issues & will release the D8 port soon.

@jyoti : I was not able to apply your patch, But i have used your code as a reference.

Below are some of the issues that i had to work on.

[1] After enabling the module and placing the block in to region it's working fine. But after clearing cache Ajax is not working.

So for that I removed the ajax callback from controller and added in to Form itself. Based on that few more changes which I did inside ajax callback.

[2] Replacing t() to $this->t().

[3] In result added the .

[4] Removal the whitespaces.

[5] Block was not visible for Anonymous User So made the changes in Block Permission.

kunalkursija’s picture

kunalkursija commented
Title: Drupal 8 version » [Meta] Porting module to D8
Status: Needs review » Needs work

Creating Tasks for this port.

kunalkursija’s picture

kunalkursija commented
Status: Needs work » Closed (fixed)

Hi Guys,

Have ported this module to D8. Thank You for the port & your contribution.