If an SKU starts with a comma (,) the function commerce_product_validate_sku($sku) will still return TRUE.

CommentFileSizeAuthor
#16 commerce_product-sku_validate-2565389-16.patch369 bytesswarad07
#15 commerce_product-sku_validate-2565389-15.patch369 bytesswarad07
#13 commerce_product-sku_validate-2565389-13.patch369 bytesswarad07
#11 commerce-sku_validate-2565389-11.patch369 bytesswarad07
#9 commerce-sku_validate_patch-2565389-9.patch369 bytesswarad07
#7 commerce-sku_validate_patch-2565389-6.patch369 bytesswarad07
#5 commerce-sku_validate_patch-2565389-5-7.x.patch369 bytesswarad07
#4 commerce-sku_validate_patch-2565389-4-7.x.patch369 bytesswarad07
#2 commerce_product-strpos-2565389-7.x.patch485 bytestinny

Comments

tinny created an issue. See original summary.

tinny’s picture

tinny commented
Status: Active » Needs review
StatusFileSize
new commerce_product-strpos-2565389-7.x.patch485 bytes

Status: Needs review » Needs work

The last submitted patch, 2: commerce_product-strpos-2565389-7.x.patch, failed testing.

swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
StatusFileSize
new commerce-sku_validate_patch-2565389-4-7.x.patch369 bytes

Rerolling.

swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Status: Needs work » Needs review
StatusFileSize
new commerce-sku_validate_patch-2565389-5-7.x.patch369 bytes

Forgot to change status

Status: Needs review » Needs work

The last submitted patch, 5: commerce-sku_validate_patch-2565389-5-7.x.patch, failed testing.

swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Status: Needs work » Needs review
StatusFileSize
new commerce-sku_validate_patch-2565389-6.patch369 bytes

Status: Needs review » Needs work

The last submitted patch, 7: commerce-sku_validate_patch-2565389-6.patch, failed testing.

swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Status: Needs work » Needs review
StatusFileSize
new commerce-sku_validate_patch-2565389-9.patch369 bytes

Status: Needs review » Needs work

The last submitted patch, 9: commerce-sku_validate_patch-2565389-9.patch, failed testing.

swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Status: Needs work » Needs review
StatusFileSize
new commerce-sku_validate-2565389-11.patch369 bytes

Now more interested in why the bot says patch file name is not valid. :-/

Status: Needs review » Needs work

The last submitted patch, 11: commerce-sku_validate-2565389-11.patch, failed testing.

swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Status: Needs work » Needs review
StatusFileSize
new commerce_product-sku_validate-2565389-13.patch369 bytes

Changing the patch name to commerce_product

Status: Needs review » Needs work

The last submitted patch, 13: commerce_product-sku_validate-2565389-13.patch, failed testing.

swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Version: 7.x-1.11 » 7.x-1.x-dev
StatusFileSize
new commerce_product-sku_validate-2565389-15.patch369 bytes
swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Status: Needs work » Needs review
StatusFileSize
new commerce_product-sku_validate-2565389-16.patch369 bytes

Adding credit.

dishabhadra’s picture

dishabhadra commented
Status: Needs review » Reviewed & tested by the community
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

swarad07, looks like you submitted a lot of moot patches? 

+++ b/modules/product/commerce_product.module
@@ -694,7 +694,6 @@ function commerce_product_validate_sku($sku) {
   }
-
   return TRUE;

Example. Not sure what happened, but #1's approach is right.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Reviewed & tested by the community » Closed (fixed)

This was actually fixed months back in #2510344: commerce_product_validate_sku() gives false positive when $sku starts with a comma.