Problem/Motivation

#1920902: Add a Drupal Yaml wrapper so we can default to PECL Yaml component if it is available would like to add support for the PECL YAML parser which is significantly faster then the in-php implementation from Symfony. To test this and make sure the included tests catch broken YAML testbot need to have the YAML extension installed.

Proposed resolution

Include PECL YAML in the php containers.

Remaining tasks

CommentFileSizeAuthor
#3 yaml.patch1.13 KBneclimdul

Comments

neclimdul created an issue. See original summary.

neclimdul’s picture

Status: Active » Needs review
StatusFileSize
new1.13 KB

Don't really know how to test this but this seems like the appropriate change.

dawehner’s picture

What about running all core tests inside a patched test runner, just to be sure?

  • 4a9e17e committed on 2565025-pecl-yaml
    Issue #2565025: adds pecl yaml to the simpletest job definition
    

  • 334881d committed on 2565025-pecl-yaml
    Issue #2565025 Installs libyaml-dev and properly tells pecl where to...
alan evans’s picture

I was just wondering why the YAML extension is only added here for 5.5 and 5.6 and the conclusion I came to was because 1) it only makes sense to add for versions that are supported on Drupal 8 and 2) Maybe there is no version of the extension available yet for PHP 7? Is that about right?

For future reference, it seems like some work has been done on it ( https://github.com/php/pecl-file_formats-yaml/tree/php7 ) but I doubt there's any easy package for install.

Oh and hi btw @neclimdul :) Long time no see ... hope you're well.

Mixologic’s picture

Mostly #2. There doesnt yet exist a stable yaml extention for php7.

neclimdul’s picture

Yeah that about sums it up.
Hey Alan! Good to "see" you. ;)

  • isntall committed fa90767 on 2565025-Add-YAML-pecl-module-to-php-container
    Issue #2565025 by neclimdul, Mixologic: Add YAML pecl module to php...
yesct’s picture

Mixologic’s picture

Component: Containers » Environments
elachlan’s picture

Project: DrupalCI: Test Runner » DrupalCI: Environments
Component: Environments » Code

Moved to DrupalCI Environments.

Mixologic’s picture

Component: Code » PHP Containers
Status: Needs review » Fixed

This now exists at the container level, and should be removed from the testrunner.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.