Like the ProcessorIntegrationTest, but more hardcore: in IntegrationTest, enable all processors (except for "Role filter", since the index does not contain users) and see what blows up (and, ideally, why).
Estimated Value and Story Points
This issue was identified as a Beta Blocker for Drupal 8. We sat down and figured out the value proposition and amount of work (story points) for this issue.
Value and Story points are in the scale of fibonacci. Our minimum is 1, our maximum is 21. The higher, the more value or work a certain issue has.
Value : 1
Story Points: 5
Comments
Comment #2
drunken monkeyCurrently blows up horribly.
Comment #4
nick_vhComment #5
borisson_Attached is a patch that enables all the processors.
Comment #6
borisson_Locally, this patch fails; I have the most recent drupal core and search_api installed.
Comment #7
drunken monkeyTest bot says the test succeeds with "249 passes", locally I get 267 – and one exception. Seems the patch once again doesn't actually get applied. The test bot really picked a great time to collapse …
Anyways, the attached patch should fix this, too. Great we actually spotted a bug here!
One other thing, though:
What do you mean with that?
Actually, I'd find it a good idea to keep the processors always enabled. But this will just enable it in a separate test case and then test nothing more, especially not indexing or searching. So I think that should be changed to be a method right at the beginning of the existing test, which enables all processors and just leaves them on for the complete test. Might change some results and thus need more changes to the test case, but we'd just have to review those to see whether they make sense or point to bugs.
Comment #8
borisson_The comment was just a description for the test, phpcs complains when a method doesn't have a description, it can be changed to anything else.
I agree that this might be better to leave them on for the complete test - setting this back to needs work.
Comment #9
borisson_Comment #10
drunken monkeyThis needed a re-roll. Also, I'd like to try whether enabling the processors before setting the fields works, too. That way, they have the most time to mess things up.
Comment #13
drunken monkeyI think that should fix it.
Comment #14
drunken monkeyRe-roll made necessary by #2473267: Verify field labels are escaped properly.
Comment #17
drunken monkeyApparently a caching problem, see also #2637032: Clear our index fields cache when entity fields are edited.
Comment #18
borisson_Looks great!
Comment #19
drunken monkeyGreat to hear, thanks for reviewing!