Add all of the Dublin Core meta tags from the D7 branch to the 8.x-1.x branch. May need to split out the meta tags into submodules after all.

CommentFileSizeAuthor
#16 metatag-n2563627-16.interdiff.txt7.38 KBdamienmckenna
#16 metatag-n2563627-16.patch18.67 KBdamienmckenna
#15 interdiff.txt17.28 KBgaurav.goyal
#15 add_all_of_the_dublin-2563627-15.patch19.12 KBgaurav.goyal
#11 add_all_of_the_dublin-2563627-11.patch1.84 KBcilefen

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2563607: Plan for Metatag 8.x-1.0-beta4 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2563607: Plan for Metatag 8.x-1.0-beta4 release » #2655294: Plan for Metatag 8.x-1.0-beta5 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2655294: Plan for Metatag 8.x-1.0-beta5 release » #2684497: Plan for Metatag 8.x-1.0-beta6 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2684497: Plan for Metatag 8.x-1.0-beta6 release » #2699057: Plan for Metatag 8.x-1.0-beta7 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2699057: Plan for Metatag 8.x-1.0-beta7 release » #2699381: Plan for Metatag 8.x-1.0-beta8 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2699381: Plan for Metatag 8.x-1.0-beta8 release » #2725269: Plan for Metatag 8.x-1.0-beta9 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2725269: Plan for Metatag 8.x-1.0-beta9 release » #2741339: Plan for Metatag 8.x-1.0-beta10 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2741339: Plan for Metatag 8.x-1.0-beta10 release »

Not putting this into beta10.

lrjohnst’s picture

lrjohnst commented

Is there anything I can help to add the Dublin Core metatags to the Metatag module?

cilefen’s picture

cilefen commented
Status: Active » Needs work
StatusFileSize
new add_all_of_the_dublin-2563627-11.patch1.84 KB

@lrjohnst The best thing IMO would be to fill in the test class.

cilefen’s picture

cilefen commented

Wait for Damien to confirm that before doing any work.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Thanks, any help is appreciated.

You could try using the DrupalConsole command generator to create all of the meta tags from the D7 branch? Add them to the new module cilefen created.

lrjohnst’s picture

lrjohnst commented

Hi Guys,

I'm afraid I was a bit overconfident with my message ealier. I never worked with the DrupalConsole before. I tried it today, but got stuck with 'segmentation fault'. Not sure if I have the right resources to even get it running. What else can I do?

In the meantime I'll keep practicing : )

gaurav.goyal’s picture

gaurav.goyal commented
Status: Needs work » Needs review
StatusFileSize
new add_all_of_the_dublin-2563627-15.patch19.12 KB
new interdiff.txt17.28 KB

Hey,

Attached is the initial patch & interdiff with patch in #11 for Dublin Core meta tags.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2563627-16.patch18.67 KB
new metatag-n2563627-16.interdiff.txt7.38 KB

Excellent work, thanks!

This is just minor tweaks.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Add all of the Dublin Core meta tags to 8.x-1.x » Add the basic Dublin Core meta tags to 8.x-1.x
Parent issue: » #2788195: Plan for Metatag 8.x-1.0-beta11 release

Lets get this into the next release.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#2809351: Add the advanced Dublin Core meta tags to 8.x-1.x

We'll handle adding the advanced Dublin Core meta tags in #2809351: Add the advanced Dublin Core meta tags to 8.x-1.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed, thank you!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +NEDCamp2016

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.