image_resize_filter 1.16 was recently released:

https://www.drupal.org/node/2544038

This will need some manual testing of resized images in the WYSIWYG.

CommentFileSizeAuthor
#5 panopoly_wysiwyg-update-image-resize-filter-2561731-5.patch718 bytesdsnopek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

I did some manual testing of this, however, it wasn't working for me until I moved the "Image resize filter" below the "Convert media tokens to markup". Which leads me to believe that we might not have actually fixed #2272721: Image Resize Filter never utilized? I'm testing on simplytest.me quick just to make sure it isn't my local environment...

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Hrm, yeah, this is broken for me on Panopoly 1.28 on simplytest.me... I think we might not actually have fixed the issue on #2272721: Image Resize Filter never utilized

wylbur’s picture

wylbur CreditAttribution: wylbur at Electric Citizen commented

We are getting a lot of errors on our site based on the code resolved in this issue:
https://www.drupal.org/node/2268737

This has been resolved in the 1.16 release, any chance to get this updated?

David, reach out to me if I can help with the testing of this!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Active » Needs review
FileSize
panopoly_wysiwyg-update-image-resize-filter-2561731-5.patch718 bytes

Here's a patch!

EDIT: Here's a Travis build: https://travis-ci.org/panopoly/panopoly/builds/323069488

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
CreditAttribution: bkosborne at Princeton University commented
Status: Needs review » Reviewed & tested by the community

We've been using the patch from #5 in production for weeks w/o issue.

  • dsnopek committed 749dc98 on 7.x-1.x 
    Update Panopoly WYSIWYG for Issue #2561731 by dsnopek, wylbur, bkosborne...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed, finally :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.