The module not work for me anymore. Problem occurs if you let module to create new users while signin (Automatically register new users = YES). I didn't find this yesterday because I tried it on already registered user :(.
Tested on simpletest.me with vanilla twitter 7.x-5.9 without patches. (I'm experiencing same bug with 7.x-5.8+100-dev)
https://dfcq9.ply.st twitter app is configured so you can try it.
Fatal error: Cannot use string offset as an array in /home/dfcq9/www/modules/user/user.module on line 2112
Warning: Missing argument 2 for user_login(), called in /home/dfcq9/www/sites/default/modules/twitter/twitter_signin/twitter_signin.module on line 222 and defined in user_login() (line 2096 of /home/dfcq9/www/modules/user/user.module).
Warning: Illegal string offset 'name' in user_login() (line 2105 of /home/dfcq9/www/modules/user/user.module).
Notice: Array to string conversion in user_login() (line 2105 of /home/dfcq9/www/modules/user/user.module).
Warning: Illegal string offset 'name' in user_login() (line 2112 of /home/dfcq9/www/modules/user/user.module).
This part probably cause it.. user_login expects $form, &$form_state params..
twitter_signin.module line ~224
// Reload the user's account object.
$account = user_login($account->uid);
I think this is pretty critical issue. I'm gonna try to patch it.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | twitter-n2561609-7-7.x-6.x.patch | 510 bytes | damienmckenna |
| #6 | twitter-n2561609-6-7.x-5.x.patch | 510 bytes | damienmckenna |
Comments
Comment #2
mkolar commentedComment #3
damienmckennaComment #4
damienmckennaDoes this resolve the problem?
Comment #5
damienmckennaI suppose replacing the existing $form_state variable might not be the best approach.
Comment #6
damienmckennaOr, you know, I could have been barking up the entirely wrong tree by using user_login() instead of user_load().
Comment #7
damienmckennaPorted to 7.x-6.x.
Comment #8
mkolar commentedI'll try it in hour..
Comment #9
damienmckennaThis only affects the two D7 branches.
Comment #10
mkolar commentedhttps://dfcd8.ply.st
installed 7.x-5.x branch with
https://www.drupal.org/files/issues/twitter-n2561609-5-7.x-5.x.patch
still
Comment #11
damienmckennaPlease test patch #6, not patch #5.
Comment #12
mkolar commentedyes, patch #6 works. You can try here: https://df2wc.ply.st
Comment #13
damienmckennaCommitted. Thanks.
Comment #21
damienmckennaThis was already committed.
Comment #23
damienmckenna