JSDoc tabledrag.js

I will work on this issue over the next couple of days

My apologies, I have run into time constraints so I wanted to set this back to unassigned.

Ran the patch in #4 through coder, and fixed suggested warnings/errors (all style related).

Fixed a few more style errors via ESLint.

Using eslint, verified that after applying the jsdoc_tabledrag_js-2559695-6.patch that there are now no errors or warnings. Thanks falufalump!

0 errors and 0 warnings with eslint. Looking good.

RTBC +1

1. +++ b/core/misc/tabledrag.js
   @@ -167,6 +167,8 @@
        /**
   +     * Check this table's settings for parent relationships.
   +     *
         * Check this table's settings to see if there are parent relationships in
         * this table. For efficiency, large sections of code can be skipped if we
   

   Could probably drop the first sentence of the paragraph since the header says the same thing.

2. +++ b/core/misc/tabledrag.js
   @@ -494,7 +512,7 @@
   -        // Safari left arrow.
   +          // Safari left arrow.
   

   Indentation changes look wrong, and there are lines untouched by the patch that have different indentation.

Here is the updated patch.

Hi,

I reviewed the patch from comment #11 and here is my review.

Things done:

1. Pulled an updated code base of 8.0.x
2. Applied the patch from comment #11
3. Installed node using brew(OSX)
4. Installed ESLint followingPhpStorm 10.0 Help /Using JavaScript Code Quality Tools

I tested with and without the patch. With the patch, there were no warnings found regarding ESLint already but I updated the change from comment #11 item #1 to follow the JavaScript API documentation and comment standards
for the short description.

Im not sure also if we need to update the tenses of the short descriptions here but based on the other core JS files they don't strictly follow the tenses.

Thanks!

+++ b/core/misc/tabledrag.js
@@ -167,8 +167,9 @@
+     * For efficiency, large sections of code can be skipped if we

Nitpick, but after you changed this, this line break comes a little early (it's way less than 80 characters)

Here is the updated patch with correction sniffed by @eiriksm

Hi @bhavikshah9,

When adding new patches above others regardless if it's yours or others, please provide an interdiff as recommended in Creating an interdiff. It will be of so much help.

Thanks!

I have reviewed also the latest patch against the latest code base of 8.0.x. Here I just included an interdiff for others to check.

Hi @leolando.tan,

Thanks a lot for the tip and an interdiff file.

No problem at all! :)

Oh no! That was part of my change on the previous patch, my bad. :( Yeah! from so much issues to the last JS file! :D

I have reviewed the patch in #20 with ESLint on PHPStorm. Everything looks good but I found one typo and just went ahead and fixed it. I hope it's alright to add it.

Thanks!

Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!