For deleting the 'taxonomy_menu', we have TaxonomyMenuDeleteForm, which we see doen't do any fancy thing.
We also see that we are using the collection link template. So in this case, we can use the core's default delete form (as our is not doing anything special) to reduce code.

Thoughts ?

CommentFileSizeAuthor
#2 2559647-2.patch1.95 KBjoshi.rohit100

Comments

joshi.rohit100 created an issue. See original summary.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Active » Needs review
StatusFileSize
new 2559647-2.patch1.95 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2559647-2.patch, failed testing.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs work » Needs review

Failure is same as here https://www.drupal.org/node/2559127

Not relevent as testcase is not there working properly.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented

I am inclined to leave this if we need to customize the delete operation moving forward. Aside from the slight added technical debt, is there any issue leaving this alone? I fully understand your point - "hey this doesn't seem needed". But, with this being a very early release, it may be advantageous to leave in until we see how the 8.x branch stabilizes.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented

I haven't seen a real need to keep this around. I'll review the patch.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
Status: Needs review » Fixed

Reviewed and merged in to 8.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.