Closed (fixed)
Project:
iDEAL advanced
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
28 Aug 2015 at 13:24 UTC
Updated:
5 Sep 2015 at 13:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mvdve commentedThe easiest way to manage the ideal_advanced payments is to create a table view within you administrator environment and use VBO to remove the test payment with the system error. This is a major error so it will keep popping up in the log until it is fixed.
The ideal_advanced payments and configurations are entities, so you can manage them as you like.
Please re-open this issue when the solution is not sufficient.
Comment #3
neograph734Then I'd like to change this to a feature request.
Perhaps you could include this table as a default View (using hook_views_default_views) in the iDEAL administration environment? That would allow users to actually see the payments as there is currently no way to interact with the payments.
Comment #4
mvdve commentedYou are right that this is a missing feature.
For a default overview of ideal payments it is possibly best to declare a custom admin page (like the configuration overview).
This way we can keep the module dependencies low.
On the other hand, views has much more features and is easy to extend. So this could be for example a sub module.
We will look in to this and add the views feature to the readme file for the time being. Feel free to contribute when you have the time.
Comment #5
mvdve commentedComment #6
neograph734The advantage of hook_views_default_view is that it is placed in MODULENAME.views_default.inc and only loaded when views is enabled. So we can simply add the file to the module and if views is enabled the views gets created. If Views is disabled nothing happens. There soft dependencies (views & vbo) can then be listed on the module page and the readme.
I can provide such a default View by this weekend.
Comment #7
mvdve commentedVery valid point. That will work best for the user and administrator as it can be easily changed. Thank you for contributing.
Comment #8
neograph734I can finish this as soon as #2559797: Add appropriate types to hook_entity_property_info() will get committed. We need to identify the properties in the right way to be able to filter and sort by them.
Comment #9
neograph734Attached patch is based on some formatters defined in #2559797: Add appropriate types to hook_entity_property_info().
I am not yet sure about the filters, there are quite a lot of them, but just let me know what you think.
Comment #10
mvdve commentedThanks for the patch!
There is a dependency on the date_views module for the created field filter.
This gave an error in the view. I think we can easily solve this by checking if the module is enabled.
Regarding the filters: These are great. The BIC filter is maybe not necessary as these are almost alike and can be derived from the IBAN number.
If you agree I would like to change some settings in the view:
- changing the machine name to a unique name, which corresponds with the module.
- adding a description.
- use sorting in the table instead of a default sort.
Please see the updated patch.
Comment #11
neograph734It is your module after all, change all the things you like ;)
I'll have a look at it tomorrow morning.
Comment #12
neograph734Patch looks ok to me, but the default now is to sort items by transaction ID in an ascending order. I suppose it would make more sense to have the latest transaction show at the top (descending order). The same applies for the dates.
Comment #13
mvdve commentedThat would indeed be a better default setting.
We also need to update the readme file with the soft dependencies and some basic instructions.
Can you make the final patch?
With these changes we are good to go!
Comment #14
neograph734I will be away from the computer for the upcoming days, so I can do it but it will be early next week. If you want to do it in the meantime, feel free.
Comment #16
mvdve commentedNo problem. The settings are changed and the view is committed. Thanks for your help!
Comment #17
neograph734Great, nice work and no problem!