The embedded tweet functionality isn't working anymore.

CommentFileSizeAuthor
#8 twitter-n2559239-8-7.x-5.x.patch11.58 KBdamienmckenna
#6 twitter-n2559239-6-7.x-5.x.patch10.41 KBdamienmckenna
#5 twitter-n2559239-5-6.x-5.x.patch10.11 KBdamienmckenna
#4 twitter-n2559239-4-7.x-6.x.patch10.41 KBdamienmckenna
#3 twitter-n2559239-2-7.x-6.x.patch8.78 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#2402307: Plan for Twitter v7.x-5.9 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new twitter-n2559239-2-7.x-6.x.patch8.78 KB

It turned out I needed to expand twitter_connect() and twitter_load_authenticated_accounts() to load the first authenticated account, regardless of other options. This had other effects elsewhere.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new twitter-n2559239-4-7.x-6.x.patch10.41 KB

Some additional improvements.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-6.x-dev » 6.x-5.x-dev
StatusFileSize
new twitter-n2559239-5-6.x-5.x.patch10.11 KB

Ported to 6.x-5.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 6.x-5.x-dev » 7.x-5.x-dev
StatusFileSize
new twitter-n2559239-6-7.x-5.x.patch10.41 KB

Ported to 7.x-5.x.

Status: Needs review » Needs work

The last submitted patch, 6: twitter-n2559239-6-7.x-5.x.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new twitter-n2559239-8-7.x-5.x.patch11.58 KB

I had my working directories mixed up, *this* is the 7.x-5.x one.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

  • DamienMcKenna committed 53bee31 on 7.x-5.x 
    Issue #2559239 by DamienMcKenna: Fixed embedded tweets, other...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed e90bb3f on 6.x-5.x 
    Issue #2559239 by DamienMcKenna: Fixed embedded tweets, other...

  • DamienMcKenna committed d9231a1 on 
    Issue #2559239 by DamienMcKenna: Fixed embedded tweets, other...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.