Closed (fixed)
Project:
Translation Management Tool
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Aug 2015 at 14:23 UTC
Updated:
3 Oct 2015 at 11:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
juanse254 commentedThis is fixing the issue aparently, some tests needed.
Comment #3
juanse254 commentedOkay, tests added
Comment #5
juanse254 commentedComment #6
berdirThat makes no sense at all ;) There is no such thing...
Comment #7
juanse254 commentedOkay, this has more sense.
Comment #8
juanse254 commentedOkay, this is the right way
Comment #9
juanse254 commentedDeleted / :).
Comment #10
LKS90 commentedBasically, looks good now.
I'm just wondering about this:
On the following line as well. Shouldn't we edit that to checkout_info as well?
Comment #11
LKS90 commentedAs discussed, that text should appear in case the translator plugin returns, for example, an empty array. So update those as well.
Comment #12
LKS90 commentedDouble Post, pls ignore.
Comment #13
miro_dietikerCan you please provide a test-only patch that shows the bug happens?
Comment #16
juanse254 commentedThe uploaded Test-Only from comment has not changed. Uploading the new patch with suggestions.
Comment #17
juanse254 commentedComment #18
LKS90 commentedA test with a translator that doesn't supply any checkout information is probably unnecessary. I'd say this patch is ready for commit.
Comment #19
berdirComment #20
berdirCommitted.