Redirection on Job Form not working

1. +++ b/src/Tests/TMGMTUiTest.php
   @@ -677,6 +677,32 @@ class TMGMTUiTest extends TMGMTTestBase {
   +    // Add item to the job.
   +    $job->addItem('test_source', 'test', 1);
   +    $this->drupalGet('admin/tmgmt/jobs/');
   

   Trailing /. Would have committed, but...

2. +++ b/tmgmt.module
   @@ -931,7 +931,8 @@ function tmgmt_job_checkout_and_redirect(FormStateInterface $form_state, array $
   -function tmgmt_submit_redirect(array $form, FormStateInterface $form_state){
   +function tmgmt_submit_redirect(array $form, FormStateInterface $form_state) {
   +  \Drupal::request()->query->remove('destination');
   

   Please add a comment that explains why we are doing this.

+++ b/tmgmt.module
@@ -931,7 +931,9 @@ function tmgmt_job_checkout_and_redirect(FormStateInterface $form_state, array $
+  // Remove the destination element from the query so the redirection works as expected.

Comment is too long (8 chars too many) and describes what the following lines do, not why they are doing it (I'm not really sure why we have to do it, probably because there is no form for the url with the destination query at the end of the URL)

1. +++ b/src/Tests/TMGMTUiTest.php
   @@ -677,6 +677,32 @@ class TMGMTUiTest extends TMGMTTestBase {
   +    $job->settings = array();
   

   Not needed for the tests?

2. +++ b/src/Tests/TMGMTUiTest.php
   @@ -677,6 +677,32 @@ class TMGMTUiTest extends TMGMTTestBase {
   +    $aborted = (array)$this->xpath('//table[@class="views-table views-view-table cols-9"]/tbody/tr[1]')[0];
   

   One missing space after (array)

3. +++ b/tmgmt.module
   @@ -931,7 +931,9 @@ function tmgmt_job_checkout_and_redirect(FormStateInterface $form_state, array $
   +  // Remove destination from the query since there is no form with it at the end.
   

   #10 is still not fixed. 1 character extra. :)

Looks good now, I'd say.

Edit: A real explanation why we have to remove the destination would be really nice though, I'm just curious though. Why is the destination query added to all requests anyway? Is it only the 'destination' element that will break the redirect or will any query elements in the request break the redirect?

Add a better explanation, the comment has to have less than 80 carachters per line, but you can add more than one line, so split the explanation in more than on line. You should configure your IDE to show these things, is so useful.

Take this in mind the next time, you are right maybe this explanation it's enough.

Comment looks fine to me. Committed.