If "Allow to send e-mails formated as HTML" checkbox is not checked, I get the WSOD and this error in the log: PHP Fatal error: Call to undefined function Drupal\\smtp\\Plugin\\Mail\\drupal_html_to_text() in /var/www/seemeqr/modules/contrib/smtp/src/Plugin/Mail/SMTPMailSystem.php on line 50.

Looks like drupal_html_to_text() is gone in D8: https://www.drupal.org/node/2359069

If I check the checkbox everything seems to work.

Also note typo 'formated' in checkbox description text.

CommentFileSizeAuthor
#5 non_html_emails_not-2557041-4.patch1.53 KBalvar0hurtad0
#2 non_html_emails_not-2557041-2.patch923 bytesalvar0hurtad0

Comments

joe casey created an issue. See original summary.

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
Status: Active » Needs review
StatusFileSize
new non_html_emails_not-2557041-2.patch923 bytes

Same error with wrapMail call.

this patch fix the 2 errors and allow send non-HTML emails.

Status: Needs review » Needs work

The last submitted patch, 2: non_html_emails_not-2557041-2.patch, failed testing.

The last submitted patch, 2: non_html_emails_not-2557041-2.patch, failed testing.

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
Status: Needs work » Needs review
StatusFileSize
new non_html_emails_not-2557041-4.patch1.53 KB

This patch add the typo on the scope and also resent the patch to check de tests.

Status: Needs review » Needs work

The last submitted patch, 5: non_html_emails_not-2557041-4.patch, failed testing.

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
Assigned: Unassigned » alvar0hurtad0

I can do it.

:D

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
Status: Needs work » Needs review

That's the situation:
IMHO the patch is OK but the CI environment detect no automated tests on the module:

8:24:46 cd /var/www/html && sudo -u www-data php /var/www/html/core/scripts/run-tests.sh  --url http://localhost/checkout --dburl mysql://drupaltestbot:drupaltestbotpw@drupaltestbot-db-mysql-5-5/jenkins_default_27273  --color --keep-results --color --concurrency 31 --sqlite /var/www/html/results/simpletest.sqlite --php /opt/phpenv/shims/php --directory modules/smtp
18:24:46 Command created as exec id 547eac04
18:24:46   ERROR: No valid tests were specified.

I've started working on automated test for this issue, but there are things out of the scope like using a schema for the configuration storage.

The last submitted patch, 2: non_html_emails_not-2557041-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 5: non_html_emails_not-2557041-4.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) commented

The patch in #5 appears to have solved the problem for me, thanks. I applied it along with the patch in https://www.drupal.org/node/2567303 and the test email sent successfully with both patches applied.

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented

@JKerschner, patch 8 also fix the problem and fix a typo. So IMHO is better using #8

Anonymous’s picture

Anonymous (not verified) commented

I don't see a patch in #8; the most recent attachment I could find is the one on #5.

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented

Haha,

:D

Sorry, you are completely right.

:D

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Reviewed & tested by the community

The last submitted patch, 2: non_html_emails_not-2557041-2.patch, failed testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: non_html_emails_not-2557041-4.patch, failed testing.

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented

To prevent the CI crash we need this issue #2612536: Create some base tests be committed.

After that we could put this issue in RTCB again.

ptmkenny’s picture

ptmkenny commented

The issue referenced in #18 was committed, so I'm re-queuing.

ptmkenny’s picture

ptmkenny commented
Status: Needs work » Reviewed & tested by the community

Re-marking RTBC based on #15.

wundo’s picture

wundo commented
Status: Reviewed & tested by the community » Fixed

  • wundo committed 4d58d80 on 8.x-1.x authored by alvar0hurtad0 
    Issue #2557041 by alvar0hurtad0, JKerschner, joe casey, ptmkenny: Non-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.