Remove t() from pass/fail assertions in tests

Just 1 nitpick:

+++ b/core/modules/simpletest/src/Tests/SimpleTestTest.php
@@ -189,7 +190,7 @@ function stubTest() {
+    $this->pass(SafeMarkup::format('Test ID is @id.', array('@id' => $this->testId)));

We could just concatenate that string so we don't have to use SafeMarkup::format() in a test.

Won't apply to 8.1.x.

Reroll of #10

1. +++ b/core/modules/field/tests/src/Kernel/FieldCrudTest.php
   @@ -113,21 +113,21 @@ function testCreateField() {
   -      FieldConfig::create($this->fieldDefinition)->save();
   -      $this->fail(t('Cannot create two fields with the same field / bundle combination.'));
   +      entity_create('field_config', $this->fieldDefinition)->save();
   +      $this->fail('Cannot create two fields with the same field / bundle combination.');
   ...
   -      FieldConfig::create($this->fieldDefinition)->save();
   -      $this->fail(t('Cannot create a field with a non-existing storage.'));
   +      entity_create('field_config', $this->fieldDefinition)->save();
   +      $this->fail('Cannot create a field with a non-existing storage.');
   
   +++ b/core/modules/field/tests/src/Kernel/FieldStorageCrudTest.php
   @@ -77,11 +77,11 @@ function testCreate() {
   -      FieldStorageConfig::create($field_storage_definition)->save();
   -      $this->fail(t('Cannot create two fields with the same name.'));
   +      entity_create('field_storage_config', $field_storage_definition)->save();
   +      $this->fail('Cannot create two fields with the same name.');
   
   @@ -90,11 +90,11 @@ function testCreate() {
   -      FieldStorageConfig::create($field_storage_definition)->save();
   -      $this->fail(t('Cannot create a field with no type.'));
   +      entity_create('field_storage_config', $field_storage_definition)->save();
   +      $this->fail('Cannot create a field with no type.');
   
   @@ -103,11 +103,11 @@ function testCreate() {
   -      FieldStorageConfig::create($field_storage_definition)->save();
   -      $this->fail(t('Cannot create an unnamed field.'));
   +      entity_create('field_storage_config', $field_storage_definition)->save();
   +      $this->fail('Cannot create an unnamed field.');
   
   @@ -129,11 +129,11 @@ function testCreate() {
   -      FieldStorageConfig::create($field_storage_definition)->save();
   -      $this->fail(t('Cannot create a field with a name starting with a digit.'));
   +      entity_create('field_storage_config', $field_storage_definition)->save();
   +      $this->fail('Cannot create a field with a name starting with a digit.');
   
   @@ -143,11 +143,11 @@ function testCreate() {
   -      FieldStorageConfig::create($field_storage_definition)->save();
   -      $this->fail(t('Cannot create a field with a name containing an illegal character.'));
   +      entity_create('field_storage_config', $field_storage_definition)->save();
   +      $this->fail('Cannot create a field with a name containing an illegal character.');
   
   @@ -157,11 +157,11 @@ function testCreate() {
   -      FieldStorageConfig::create($field_storage_definition)->save();
   -      $this->fail(t('Cannot create a field with a name longer than 32 characters.'));
   +      entity_create('field_storage_config', $field_storage_definition)->save();
   +      $this->fail('Cannot create a field with a name longer than 32 characters.');
   
   @@ -172,11 +172,11 @@ function testCreate() {
   -      FieldStorageConfig::create($field_storage_definition)->save();
   -      $this->fail(t('Cannot create a field bearing the name of an entity key.'));
   +      entity_create('field_storage_config', $field_storage_definition)->save();
   +      $this->fail('Cannot create a field bearing the name of an entity key.');
   
   +++ b/core/modules/node/src/Tests/NodeCreationTest.php
   @@ -86,11 +86,11 @@ function testFailedPageCreation() {
   -      Node::create($edit)->save();
   -      $this->fail(t('Expected exception has not been thrown.'));
   +      entity_create('node', $edit)->save();
   +      $this->fail('Expected exception has not been thrown.');
   

   entity_create() and so forth have been deprecated, and so we want to keep the EntityType::create() methods in place.

2. +++ b/core/modules/system/tests/src/Kernel/Extension/ModuleHandlerTest.php
   @@ -120,10 +120,10 @@ function testDependencyResolution() {
   -    catch (MissingDependencyException $e) {
   -      $this->pass(t('ModuleInstaller::install() throws an exception if dependencies are missing.'));
   +    catch (\Drupal\Core\Extension\MissingDependencyException $e) {
   +      $this->pass('ModuleInstaller::install() throws an exception if dependencies are missing.');
   

   We don't need the fully qualified class name here for the exception. MissingDependencyException has a use statement at the top of the file.

3. +++ b/core/tests/Drupal/KernelTests/Core/Database/TransactionTest.php
   @@ -297,7 +297,7 @@ function testTransactionWithDdlStatement() {
            // @TODO: an exception should be triggered here, but is not, because
            // "ROLLBACK" fails silently in MySQL if there is no transaction active.
   -        // $this->fail(t('Rolling back a transaction containing DDL should fail.'));
   +        // $this->fail('Rolling back a transaction containing DDL should fail.');
   

   Fixing the commented code! :-)

   I couldn't find an issue for the @todo anywhere, so I made one: #2736777: MySQL on PHP 8 now errors when committing or rolling back when there is no active transaction

#15.3 still applies... Edit the @todo so it points to the issue.

I'm not sure with the change done in #6 IMO for consistency with core we should use:

$this->pass(new FormattableMarkup('Test ID is @id.', ['@id' => $this->testId]));

The performance impact is low and the print is safely by default; But the patch is fine and secure with or without the formattable markup :)

Random js test fail.

Less strings for translators to translate - nice and less t() seems a good idea.

Committed b644848 and pushed to 8.8.x. Thanks!