Closed (outdated)
Project:
Admin Toolbar
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Minor
Category:
Bug report
Assigned:
Reporter:
Created:
18 Aug 2015 at 09:05 UTC
Updated:
29 Apr 2016 at 17:08 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
yoruvo commentedHere's a small patch fixing the most glaring issues.
Comment #3
gokulnk commentedGood to go.
Comment #4
dbt102 commentedI think this issue has kind of languished because it touches on a lot of different parts of the code, and applying the patch submitted, may actually undo progress made in other areas. What I'd like to do it to adjust the status back to activce, then examine each chunk of the #2 patch to see (1) if the spelling grammar item still requires attention and (2) if it does, try to address the best way to get it fixed.
The first chunk (that follows) was fixed by Commit e5b7ef6 on 8.x-1.x
Comment #5
dbt102 commentedThe next chunk (following) addresses the admin_toolbar "Help".
The release notes for Drupal 8.1.0 indicates an " Improved site administration experience: * Improved admin/help page to be more flexible and list tours on it."
Comment #6
dbt102 commentedSo, per my comment above (#5), I've created another issue Update Admin Toolbar "Help" to implement 'Help' in a manner that is patterned after the new revised way to do it.
Comment #7
dbt102 commentedI've got a good workflow going on getting this issue resolved, so I'm assigning it to myself and will treat it as the parent issue for the other fixes as things develop.
Comment #8
dbt102 commentedComment #9
dbt102 commentedJust submitted patch #7 at #2713899: Update Admin Toolbar HELP which covers the chunk in comment #5
Comment #10
dbt102 commentedI created a new issue #2715685: Cleanup Admin Toolbar Extra Tools administration pages to discuss this next chunk.
That whole section seems kind of out of place to me,
Comment #11
dbt102 commentedThe chunk mentioned in #10 above was fixed in this commit on 8.x-1.x (4/27/16) --> http://drupalcode.org/project/admin_toolbar.git/commit/26dbb6b
Comment #12
dbt102 commentedso, that just leaves the last chunk
Comment #13
dbt102 commented1. this part is already fixed -->
2. this part has not been changed -->
NOTE: I'm not sure at the moment, but my initial impression is that neither would be the 'correct' reference. It links to here --> https://api.drupal.org/api/drupal/8.2.x and that site "Welcomes" the user "to the Drupal API Documentation!" . So I'd say if it gets changed, it gets changed to something like _title: 'Drupal API Documentation' will defer this to a later issue.
Comment #14
dbt102 commentedClosing out this issue as "fixed" because I have reviewed all the misc. edits in the patches here, and have found that they have all been addressed.
Comment #15
dbt102 commented