In "Run cron", "cron" is written lowercase, while in "Run Updates" the word "Updates" is written in uppercase. In addition, various descriptions contain wrong grammar and typos.

Comments

ividyon created an issue. See original summary.

yoruvo’s picture

Title: Minor discrepancy between menu item labels » Minor spelling/grammar issues
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new2.81 KB

Here's a small patch fixing the most glaring issues.

gokulnk’s picture

Status: Needs review » Reviewed & tested by the community

Good to go.

dbt102’s picture

Status: Reviewed & tested by the community » Active

I think this issue has kind of languished because it touches on a lot of different parts of the code, and applying the patch submitted, may actually undo progress made in other areas. What I'd like to do it to adjust the status back to activce, then examine each chunk of the #2 patch to see (1) if the spelling grammar item still requires attention and (2) if it does, try to address the best way to get it fixed.

The first chunk (that follows) was fixed by Commit e5b7ef6 on 8.x-1.x

@@ -1,6 +1,6 @@
name: Admin Toolbar
core: 8.x
-description: Admin Toolbar improve the default Drupal Toolbar,it lets the hover of sub menus.
+description: Improves the default Drupal 8 Toolbar by adding on-hover drop-down menus.
package: Administration
type: module
version: 1.0
diff --git a/admin_toolbar_tools/admin_toolbar_tools.module b/admin_toolbar_tools/admin_toolbar_tools.module
index 3d34349..3ac8a82 100644
--- a/admin_toolbar_tools/admin_toolbar_tools.module
+++ b/admin_toolbar_tools/admin_toolbar_tools.module

dbt102’s picture

The next chunk (following) addresses the admin_toolbar "Help".

The release notes for Drupal 8.1.0 indicates an " Improved site administration experience: * Improved admin/help page to be more flexible and list tours on it."

@@ -34,7 +34,7 @@ function admin_toolbar_tools_help($route_name, RouteMatchInterface $route_match)
     case 'help.page.admin_toolbar_tools':
       $output = '';
       $output .= '<h3>' . t('About') . '</h3>';
-      $output .= '<p>' . t('The Admin Toolbar Tools module allows you to to add more fonctionalities to the toolbar like flush caches, runnig cron.') . '</p>';
+      $output .= '<p>' . t('The Admin Toolbar Tools module adds developer functionality like flushing caches and running cron tasks to your toolbar.') . '</p>';
       return $output;
   }
 }
dbt102’s picture

So, per my comment above (#5), I've created another issue Update Admin Toolbar "Help" to implement 'Help' in a manner that is patterned after the new revised way to do it.

dbt102’s picture

I've got a good workflow going on getting this issue resolved, so I'm assigning it to myself and will treat it as the parent issue for the other fixes as things develop.

dbt102’s picture

Assigned: yoruvo » dbt102
dbt102’s picture

Just submitted patch #7 at #2713899: Update Admin Toolbar HELP which covers the chunk in comment #5

dbt102’s picture

I created a new issue #2715685: Cleanup Admin Toolbar Extra Tools administration pages to discuss this next chunk.

That whole section seems kind of out of place to me,

@@ -64,7 +64,7 @@ function admin_toolbar_tools_menu_links_discovered_alter(&$links) {
       'weight' => -8
     );
     $links['system.db_update'] = array(
-      'title' => 'Run Updates',
+      'title' => 'Run updates',
       'route_name' => 'system.db_update',
       'parent' => 'admin_toolbar_tools.help',
       'weight' => -6
@@ -345,4 +345,4 @@ function admin_toolbar_tools_menu_links_discovered_alter(&$links) {
     );
 
   }
-}
\ No newline at end of file
+}
dbt102’s picture

The chunk mentioned in #10 above was fixed in this commit on 8.x-1.x (4/27/16) --> http://drupalcode.org/project/admin_toolbar.git/commit/26dbb6b

dbt102’s picture

so, that just leaves the last chunk

diff --git a/admin_toolbar_tools/admin_toolbar_tools.routing.yml b/admin_toolbar_tools/admin_toolbar_tools.routing.yml
index 22f1eb2..a925dd0 100644
--- a/admin_toolbar_tools/admin_toolbar_tools.routing.yml
+++ b/admin_toolbar_tools/admin_toolbar_tools.routing.yml
@@ -10,7 +10,7 @@ admin_toolbar_tools.cssjs:
   path: '/admin/flush/cssjs'
   defaults:
     _controller: '\Drupal\admin_toolbar_tools\Controller\ToolbarController::flush_js_css'
-    _title: 'Flush Css and Javascript'
+    _title: 'Flush CSS and JavaScript'
   requirements:
     _permission: 'access administration pages'
     _csrf_token: 'TRUE'
@@ -58,7 +58,7 @@ admin_toolbar_tools.doc:
   path: '/admin/drupal/documentation'
   defaults:
     _controller: '\Drupal\admin_toolbar_tools\Controller\ToolbarController::documentation'
-    _title: 'Documentation D8'
+    _title: 'D8 documentation'
   requirements:
     _permission: 'access administration pages'
     _csrf_token: 'TRUE'
@@ -77,4 +77,4 @@ admin_toolbar.run.cron:
     _title: 'Run cron'
   requirements:
     _permission: 'access administration pages'
-    _csrf_token: 'TRUE'
\ No newline at end of file
+    _csrf_token: 'TRUE'
dbt102’s picture

1. this part is already fixed -->

-    _title: 'Flush Css and Javascript'
+    _title: 'Flush CSS and JavaScript'

2. this part has not been changed -->

-    _title: 'Documentation D8'
+    _title: 'D8 documentation'

NOTE: I'm not sure at the moment, but my initial impression is that neither would be the 'correct' reference. It links to here --> https://api.drupal.org/api/drupal/8.2.x and that site "Welcomes" the user "to the Drupal API Documentation!" . So I'd say if it gets changed, it gets changed to something like _title: 'Drupal API Documentation' will defer this to a later issue.

dbt102’s picture

Status: Active » Fixed

Closing out this issue as "fixed" because I have reviewed all the misc. edits in the patches here, and have found that they have all been addressed.

dbt102’s picture

Status: Fixed » Closed (outdated)