Function commerce_coupon_load_coupon_code_discounts does not work since commerce_discount module renamed schema field "enabled" to "status"

CommentFileSizeAuthor
#13 2552657-13.patch3.17 KBmglaman
#11 2552657-11.patch3.16 KBmglaman
#8 2552657-8.patch2.58 KBmglaman
#4 commerce_coupon_load_coupon_code_discounts.patch1.15 KBxsdx

Comments

blueyestar created an issue. See original summary.

drupov’s picture

drupov commented
Version: 7.x-2.0-rc2 » 7.x-2.x-dev
Priority: Normal » Major

The problem is also that the function queries for a non-existing field commerce_coupon_reference

xsdx’s picture

xsdx commented

Confirming the bug exists

xsdx’s picture

xsdx commented
StatusFileSize
new commerce_coupon_load_coupon_code_discounts.patch1.15 KB

Providing patch for issue

xsdx’s picture

xsdx commented
Status: Active » Needs review

Please someone review the patch. Tnx

tamerzg’s picture

tamerzg commented
Status: Needs review » Reviewed & tested by the community

Patch in #4 works for me.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Related issues: +#1854108: Refactor discount view filters and alter schema

Linking related issue which caused changed.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2552657-8.patch2.58 KB

Updated patch which also adds test.

Status: Needs review » Needs work

The last submitted patch, 8: 2552657-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Did this function ever work? The commerce_coupon_reference is not found anywhere in current code base.

Edit: Re-read. That is what #2 confirms, and #4 fixes.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2552657-11.patch3.16 KB

Okay, this should pass, now.

Status: Needs review » Needs work

The last submitted patch, 11: 2552657-11.patch, failed testing. View results

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2552657-13.patch3.17 KB

Oops. PhpStorm converted to short array syntax in new test.

  • mglaman committed 1ca70b4 on 7.x-2.x authored by xSDx 
    Issue #2552657 by mglaman, xSDx, drupov, tamerzg:...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Committed. Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.