All tabledrag-handle anchors appear broken when there's a stylesheet with Paul Irish's box-sizing snippet (http://www.paulirish.com/2012/box-sizing-border-box-ftw/), which is very common and on a lot of sites.
html {
box-sizing: border-box;
}
*, *:before, *:after {
box-sizing: inherit;
}Or
*, *:before, *:after {
box-sizing: border-box;
}Drupal.org even has this problem but fixes it by using a separate stylesheet with
a.tabledrag-handle .handle {
height: 2em;
width: 2em;
}caniuse reference (http://caniuse.com/#feat=css3-boxsizing)
Simple fix, add box-sizing: content-box; to .draggable a.tabledrag-handle in system.base.css
Needs screenshots/STR/Review
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | 2552195-14.patch | 479 bytes | jay jangid |
| #14 | Patch corrupt.PNG | 21.57 KB | jay jangid |
| #12 | 2552195_12.patch | 489 bytes | athyamvidyasagar |
| #10 | 2552195-10.patch | 473 bytes | Shubham Sharma 77 |
| #9 | 2552195-nr-bot.txt | 143 bytes | needs-review-queue-bot |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
johnalbinComment #3
nathan tsai commentedThis issue is still present in Drupal 9.3.
https://git.drupalcode.org/project/drupal/-/blob/9.3.x/core/modules/syst...
I needed to add to the following code today.
Don't know if we just leave it to the developers to deal with it, or we want to avoid potential conflicts down the road.
Comment #6
rafaellapinho commentedThe issue is happening on Drupal version 9.4.9 and Admin theme Seven. With the default Drupal 9 admin theme (Claro) the issue is not happening. Then I created a patch for the seven theme.
Comment #7
rafaellapinho commentedI created an issue to the seven theme: https://www.drupal.org/project/seven/issues/3333866
Comment #8
muskan kumari commentedPlease add below CSS code in Drupal Seven theme:
-webkit-box-sizing: content-box;
box-sizing: content-box;
Comment #9
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #10
Shubham Sharma 77 commentedFixed failed commands on #6 and addressed comment #8
Attached reroll patch against Drupal 9.5.x. Please review it.
Comment #12
athyamvidyasagar commentedAble to replicate this issue on Drupal 9.5.0 Seven admin theme, fixed and created a patch for the same.
Comment #13
jay jangid commentedComment #14
jay jangid commentedAfter apply Patch #12 ,it showing patch corrupt.
Create new patch according to patch #12.
Please review.
Comment #16
ricksta commentedCould I get please get more information on this, maybe someone layout the steps reviewers should follow to see the bug? I'm not seeing a problem. I see patches for the Seven theme which is marked as deprecated and not installed on a fresh D9.5 site.
Comment #17
gauravvvv commentedComment #19
gauravvvv commentedComment #20
smustgrave commentedIssue summary should follow standard template, which includes UI changes.
Comment #21
djsagar commentedNeed more information to reproduce this issue, so update issue tags.
it's really helpful if someone share the STR.
Thanks!
Comment #22
shweta__sharma commentedAdded standard IS template still screenshots and STR required. Leaving it in needs works status for now.