#2543258: Entity references of untranslatable fields are not displayed in the correct translation changes the viewElements() and getEntitiesToView() methods to have a second parameter called $langcode. The $langcode variable is used to determine the field's language context.
When that issue is fixed, we have to update the module's viewElements() and getEntitiesToView() methods as well.
Add the $langcode parameter and use it correctly when displaying fields.
Wait for core patch to be committed, review patch, commit.
None
None
None
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | entity-reference-langcode-2551365-6.patch | 2.87 KB | berdir |
| #2 | updateFieldFormatter.patch | 2.92 KB | LKS90 |
Comments
Comment #2
LKS90 commentedMight as well create a postponed issue and store the patch here :).
Comment #3
kataku commentedBeen reviewing this issue and i've written the exact same fix before finding this. I've commented on #2543258 to confirm their patch works there and I've used more or less the same fix posted here.
Why are this and the related issues postponed?
Comment #4
miro_dietikerBecause they are postponed on the core issue. As soon as the core issue is committed, the fixes make sense. Before they don't.
Comment #5
berdirThis has been committed now. The patch needs to be simplified, remove the fallback stuff, just pass $langcode along.
Comment #6
berdirNew patch. Added $langcode argument and changed EntityReferenceRevisionsFormatterBase to extend from EntityReferenceFormatterBase. Plenty of methods are identical, including the affected getEntitiesToView().
Comment #7
berdirManually tested paragraph tests, they are finally green again with this!
Comment #8
miro_dietikerCommitted, thx!