in function ip_backlog_nodes(), a query is run on the watchdog table.
This means that the dblog module is requried for ip to function.
A dependency should be set for dblog in the info file so that the watchdog module is also enabled along with this module.

CommentFileSizeAuthor
#2 dependency_on_dblog-2549877-2.patch249 bytespravin ajaaz

Comments

alansaviolobo created an issue. See original summary.

pravin ajaaz’s picture

pravin ajaaz commented
StatusFileSize
new dependency_on_dblog-2549877-2.patch249 bytes

patch to fix it

pravin ajaaz’s picture

pravin ajaaz commented
Status: Active » Needs review
pravin ajaaz’s picture

pravin ajaaz commented
alansaviolobo’s picture

alansaviolobo commented
Status: Needs review » Needs work

isnt it possible to remove the dependency on db log completely by refactoring ip_backlog_nodes() and using the same strategy as ip_backlog_comments() ?

alansaviolobo’s picture

alansaviolobo commented
Related issues: +#2586099: purpose of function ip_cron() ?

My bad.

The node table doesn't seem to have an IP tracking column while the same is present in the comment table. Hence the difference in implementation.

Have raised another question whether the hook_cron is really required.

gedur’s picture

gedur commented

This is something I want to refactor, more info in the issue #2586099: purpose of function ip_cron() ? anyway I think that use a module_exists could be a better approach.

pravin ajaaz’s picture

pravin ajaaz commented
gedur’s picture

gedur commented
Status: Needs work » Fixed

Module now checks is dblog is enabled before query to watchdog table.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.