The dafult sign for CHF (Swiss franc) is Fr. or SFr. or FS and not ₣ as mentioned in currency/currency/vendor/bartfeenstra/currency/resources/CHF.yml.

See also: https://en.wikipedia.org/wiki/Swiss_franc

The default rounding_step of the CHF should be 0.05 (https://en.wikipedia.org/wiki/Swedish_rounding)

CommentFileSizeAuthor
#4 currency-wrong-default-sign-for-chf-2549289-4.patch491 bytesvalentin schmid
#3 wrong_default_sign_for-2549289-3.patch447 bytespravin ajaaz
#2 wrong_default_sign_for-2549289-2.patch449 bytespravin ajaaz

Comments

valentin schmid created an issue. See original summary.

pravin ajaaz’s picture

pravin ajaaz commented
Status: Active » Needs review
StatusFileSize
new wrong_default_sign_for-2549289-2.patch449 bytes

Patch to change it as Fr

pravin ajaaz’s picture

pravin ajaaz commented
StatusFileSize
new wrong_default_sign_for-2549289-3.patch447 bytes

Sorry here is the correct one.

valentin schmid’s picture

valentin schmid commented
StatusFileSize
new currency-wrong-default-sign-for-chf-2549289-4.patch491 bytes

The correct sign should be 'Fr.' (not '₣r').
Here's another patch containg the alternative signs as well.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Version: 7.x-2.x-dev » 8.x-3.x-dev
Status: Needs review » Needs work

Thanks for reporting and working on this! To make sure we don't introduce regressions, this needs to be fixed in 8.x-3.x first. Then, for 7.x-2.x, this needs to be fixed at https://github.com/bartfeenstra/currency.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Closed (won't fix)

Currency 8.x-3.x now uses https://github.com/Commercie/currency and no longer contains its own currency information, which means this issue must be fixed first in https://github.com/Commercie/currency and then in https://github.com/bartfeenstra/currency.

valentin schmid’s picture

valentin schmid commented

Is this issue already reported in https://github.com/Commercie/currency ?
If not, who will do that?

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

It's not. Could you create a pull request there?

valentin schmid’s picture

valentin schmid commented

Added an issue:
https://github.com/Commercie/currency/issues/2