Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
remove unused variables and code:
/src/PHPMailer/PHPMailer.php
Unused variable $key.
Unused variable $tmp.
/src/Form/SMTPConfigForm.php
Unused variable $params.
/src/Plugin/Mail/SMTPMailSystem.php
Unused variable $id.
Comment | File | Size | Author |
---|---|---|---|
#10 | remove_unused_variables-2548145-10.patch | 497 bytes | pazhyn |
#7 | apply_removed_variables_and_reverted_body_field-2548145-5.patch | 3.57 KB | Denys Terentiev |
#2 | Removed-unused-varibales-and-code-2548145-1.patch | 2.75 KB | rrfegade |
Comments
Comment #2
rrfegade CreditAttribution: rrfegade as a volunteer commentedpfa the patch
Comment #3
wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commentedNeeds re-roll
Comment #4
Denys Terentiev CreditAttribution: Denys Terentiev at AnyforSoft commentedComment #7
Denys Terentiev CreditAttribution: Denys Terentiev at AnyforSoft commentedComment #8
Denys Terentiev CreditAttribution: Denys Terentiev at AnyforSoft commentedComment #9
pazhyn CreditAttribution: pazhyn as a volunteer and at AnyforSoft, Drupal Ukraine Community commentedPatch from #7 also changing file permissions.
Needs work.
Comment #10
pazhyn CreditAttribution: pazhyn as a volunteer and at AnyforSoft, Drupal Ukraine Community commentedRemoved unused variable $id.
Another unused variable for now $from_name is used in https://www.drupal.org/node/2659748
PHPMailer should be set as external library in https://www.drupal.org/node/2711559
Comment #11
pazhyn CreditAttribution: pazhyn as a volunteer and at AnyforSoft, Drupal Ukraine Community commentedComment #12
pazhyn CreditAttribution: pazhyn as a volunteer and at AnyforSoft, Drupal Ukraine Community commentedComment #13
zviryatko CreditAttribution: zviryatko at AnyforSoft, Drupal Ukraine Community commentedComment #14
estoyausenteIt's ok, it is the only one unused variable that I found too.
Comment #16
wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented