remove unused variables and code:
/src/PHPMailer/PHPMailer.php
Unused variable $key.
Unused variable $tmp.

/src/Form/SMTPConfigForm.php
Unused variable $params.

/src/Plugin/Mail/SMTPMailSystem.php
Unused variable $id.

CommentFileSizeAuthor
#10 remove_unused_variables-2548145-10.patch497 bytespazhyn
#7 apply_removed_variables_and_reverted_body_field-2548145-5.patch3.57 KBDenys Terentiev
#4 apply_removed_variables_and_reverted_body_field-2548145-4.patch2.81 KBDenys Terentiev
#2 Removed-unused-varibales-and-code-2548145-1.patch2.75 KBrrfegade

Comments

rrfegade created an issue. See original summary.

rrfegade’s picture

rrfegade commented
Status: Active » Needs review
StatusFileSize
new Removed-unused-varibales-and-code-2548145-1.patch2.75 KB

pfa the patch

wundo’s picture

wundo commented
Status: Needs review » Needs work

Needs re-roll

Denys Terentiev’s picture

Denys Terentiev commented
Status: Needs work » Needs review
StatusFileSize
new apply_removed_variables_and_reverted_body_field-2548145-4.patch2.81 KB

Status: Needs review » Needs work

The last submitted patch, 4: apply_removed_variables_and_reverted_body_field-2548145-4.patch, failed testing.

The last submitted patch, 4: apply_removed_variables_and_reverted_body_field-2548145-4.patch, failed testing.

Denys Terentiev’s picture

Denys Terentiev commented
Status: Needs work » Needs review
StatusFileSize
new apply_removed_variables_and_reverted_body_field-2548145-5.patch3.57 KB
Denys Terentiev’s picture

Denys Terentiev commented
pazhyn’s picture

pazhyn commented
Status: Needs review » Needs work

Patch from #7 also changing file permissions.
Needs work.

pazhyn’s picture

pazhyn commented
Assigned: rrfegade » Unassigned
Status: Needs work » Needs review
StatusFileSize
new remove_unused_variables-2548145-10.patch497 bytes

Removed unused variable $id.
Another unused variable for now $from_name is used in https://www.drupal.org/node/2659748
PHPMailer should be set as external library in https://www.drupal.org/node/2711559

pazhyn’s picture

pazhyn commented
Component: Documentation » Code
pazhyn’s picture

pazhyn commented
Issue tags: +DrupalCamp Kyiv, +CodeSprintUA
zviryatko’s picture

zviryatko commented
Status: Needs review » Reviewed & tested by the community
estoyausente’s picture

estoyausente
Primary language Spanish
commented

It's ok, it is the only one unused variable that I found too.

  • wundo committed bd417f0 on 8.x-1.x authored by pazhyn 
    Issue #2548145 by Denys Terentiev, pazhyn, rrfegade, zviryatko, wundo,...
wundo’s picture

wundo commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.