This is a very rough sketch

CommentFileSizeAuthor
#53 interdiff-49-53.txt2.8 KBMerryHamster
#53 2546280-53.patch6.31 KBMerryHamster
#52 interdiff-49-52.txt3.39 KBMerryHamster
#52 2546280-52.patch3.75 KBMerryHamster
#49 2546280-49.patch6.52 KBjofitz
#49 interdiff-46-49.txt2.08 KBjofitz
#46 2546280-46.patch7.33 KBjofitz
#46 interdiff-41-46.txt1.86 KBjofitz
#44 2546280-44.patch48.08 KBchiranjeeb2410
#41 2546280-41-D8.patch6.73 KBmohit1604
#38 2546280-38.patch6.81 KBchiranjeeb2410
#36 test-branch.patch6.7 KBchiranjeeb2410
#34 2546280-34.patch6.31 KBchiranjeeb2410
#28 2546280-28-D8.patch5.36 KBmohit1604
#18 2546280-18.patch3.7 KBanhtq
#7 2546280.7.patch6.38 KBhussainweb
#7 interdiff-4-7.txt1.2 KBhussainweb
#4 2546280.4.patch6.39 KBalexpott
#2 2546280.2.patch5.2 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2546280.2.patch5.2 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2546280.2.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 2546280.4.patch6.39 KB

Rerolled and improved a little.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Needs beta evaluation

Kinda interesting, and the ability to add themeability and pass around a classed object is intriguing too, but I'm not sure about this beta-wise because it's adding new API rather than fixing what is (IMO) a blocker for and bug with dsm() output and safeness currently.

What this wouldn't cover that render arrays do is the case where you want to assemble a render array and it's not a list, e.g. appending two t() results together in a paragraph with some whitespace or stuff with prefixes/suffixes.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

appending two t() results together in a paragraph

But this should not be in a message.

hussainweb’s picture

hussainweb
Primary language English
commented
StatusFileSize
new interdiff-4-7.txt1.2 KB
new 2546280.7.patch6.38 KB

Uber nitpicks. :)

xjm’s picture

xjm
she/her
Primary language English
commented
appending two t() results together in a paragraph

But this should not be in a message.

Why not? Also, tell that to the code that does this. ;)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

re #5 Well I think this API could be beta permissible as it solves the problem we have in file_save_upload(), _node_mass_update_batch_finished(), and the example code in callback_batch_finished. Also ConfigSync::finishBatch() could do with this tbh. Found another... update_manager_download_batch_finished - this will put the title in a <h3> in the messages block (nice).

xjm’s picture

xjm
she/her
Primary language English
commented

I really don't think this is beta-eligible, unfortunately.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Needs work

Needs work in light of #2278383: Create an injectible service for drupal_set_message()

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: -Needs beta evaluation +Needs reroll
ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented
Issue tags: +DrupalMumbaiCodeSprint
anhtq’s picture

anhtq commented
StatusFileSize
new 2546280-18.patch3.7 KB

(For Google Code-In)
The patch in #2 has been rerolled :)

chiranjeeb2410’s picture

chiranjeeb2410 commented
Status: Needs work » Needs review

@anhtq,

Patched applies cleanly. Successful reroll!

anhtq’s picture

anhtq commented

Good to hear that !

mohit1604’s picture

mohit1604 commented

Just to inform you , drupal_set_message and drupal_get_message have been deprecated in version 8.5.x and replaced by messenger service ;)
see this for more information.

mohit1604’s picture

mohit1604 commented

Added test to patch #18 , hope it goes green !

mohit1604’s picture

mohit1604 commented
Assigned: Unassigned » mohit1604

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mohit1604’s picture

mohit1604 commented
Version: 8.5.x-dev » 8.4.x-dev
Assigned: mohit1604 » Unassigned

Made patch for 8.4.x now working for 8.5.x according to comment #24 .

mohit1604’s picture

mohit1604 commented
Version: 8.4.x-dev » 8.5.x-dev
Assigned: Unassigned » mohit1604
mohit1604’s picture

mohit1604 commented

drupal_set_message and drupal_get_message have been deprecated in version 8.5.x (see comment #21), should we need a patch for 8.5.x for this issue ?

mohit1604’s picture

mohit1604 commented
StatusFileSize
new 2546280-28-D8.patch5.36 KB

Patch for 8.4.x , hope it shows green ;)

Status: Needs review » Needs work

The last submitted patch, 28: 2546280-28-D8.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 8.5.x-dev » 8.6.x-dev

Patches should be filed for current dev version

mohit1604’s picture

mohit1604 commented

Patch #28 failed testing due to following error :-
error: core/lib/Drupal/Core/Utility/Message.php: No such file or directory
error: core/modules/system/templates/status-message.html.twig: No such file or directory

These 2 files are the new files that have been added to working directory while creating this patch! I used git diff to create the patch , What should I use so that automated test can identify these as new files ?

chiranjeeb2410’s picture

chiranjeeb2410 commented
Version: 8.6.x-dev » 8.4.x-dev
Assigned: mohit1604 » Unassigned
Status: Needs work » Needs review

@Mohit Malik, try uploading a fresh patch according to the latest version update.

chiranjeeb2410’s picture

chiranjeeb2410 commented
Version: 8.4.x-dev » 8.6.x-dev
Status: Needs review » Needs work
chiranjeeb2410’s picture

chiranjeeb2410 commented
Status: Needs work » Needs review
StatusFileSize
new 2546280-34.patch6.31 KB

Status: Needs review » Needs work

The last submitted patch, 34: 2546280-34.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

chiranjeeb2410’s picture

chiranjeeb2410 commented
Status: Needs work » Needs review
StatusFileSize
new test-branch.patch6.7 KB

Rerolled. Should be green.

Status: Needs review » Needs work

The last submitted patch, 36: test-branch.patch, failed testing. View results

chiranjeeb2410’s picture

chiranjeeb2410 commented
Status: Needs work » Needs review
StatusFileSize
new 2546280-38.patch6.81 KB

Status: Needs review » Needs work

The last submitted patch, 38: 2546280-38.patch, failed testing. View results

mohit1604’s picture

mohit1604 commented
Assigned: Unassigned » mohit1604
Status: Needs work » Needs review
mohit1604’s picture

mohit1604 commented
StatusFileSize
new 2546280-41-D8.patch6.73 KB

Hoping to show green this time !

Status: Needs review » Needs work

The last submitted patch, 41: 2546280-41-D8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mohit1604’s picture

mohit1604 commented
Assigned: mohit1604 » Unassigned
chiranjeeb2410’s picture

chiranjeeb2410 commented
Status: Needs work » Needs review
StatusFileSize
new 2546280-44.patch48.08 KB

Status: Needs review » Needs work

The last submitted patch, 44: 2546280-44.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new interdiff-41-46.txt1.86 KB
new 2546280-46.patch7.33 KB

Correct test failure.

Please remember to include an interdiff with a new patch.

Status: Needs review » Needs work

The last submitted patch, 46: 2546280-46.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

chiranjeeb2410’s picture

chiranjeeb2410 commented

@Jo Fitzgerald,

I think the reroll needs to be done for the patch in comment #7, since none of the patches after that have passed
automated testing.

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-46-49.txt2.08 KB
new 2546280-49.patch6.52 KB

Re-roll of patch from #7 (with interdiff against patch in #46).

Status: Needs review » Needs work

The last submitted patch, 49: 2546280-49.patch, failed testing. View results

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Needs issue summary update
MerryHamster’s picture

MerryHamster commented
StatusFileSize
new 2546280-52.patch3.75 KB
new interdiff-49-52.txt3.39 KB

sorry here the wrong patch, I added the patch to #53

MerryHamster’s picture

MerryHamster commented
StatusFileSize
new 2546280-53.patch6.31 KB
new interdiff-49-53.txt2.8 KB

Renamed SafeStringInterface to MarkupInterface according to https://www.drupal.org/project/drupal/issues/2576533
and https://www.drupal.org/node/2549395

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 53: 2546280-53.patch, failed testing. View results

dawehner’s picture

dawehner
Primary language German
commented

@alexpott Do you mind describing the intention of this?
In the case we are doing that, we also need a followup of #77245: Provide a common API for displaying JavaScript messages

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.