Building on the work of @samvel and @mdixoncm in https://www.drupal.org/node/1888102 I've created a patch for Paragraphs compatibility. It can almost certainly be neatened up as it shares a lot of similar code with their patch

CommentFileSizeAuthor
#11 interdiff_5-11.txt2.01 KBmkindred
#11 linkchecker-support-paragraphs-2546090-11.patch1.6 KBmkindred
#6 linkchecker-support_paragraphs-2546090-5.patch2.08 KBRudi Teschner
#4 linkchecker-support_paragraphs-2546090-4.patch2.33 KBRudi Teschner
#2 support-paragraphs-2546090-1.patch2.22 KBversantus.nik
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

versantus created an issue. See original summary.

versantus.nik’s picture

versantus.nik CreditAttribution: versantus.nik as a volunteer and commented
Issue summary: View changes
FileSize
support-paragraphs-2546090-1.patch2.22 KB
versantus.nik’s picture

versantus.nik CreditAttribution: versantus.nik as a volunteer and commented
Status: Active » Needs review
Rudi Teschner’s picture

Rudi Teschner CreditAttribution: Rudi Teschner commented
FileSize
linkchecker-support_paragraphs-2546090-4.patch2.33 KB

Using this patch I get some array_flip errors:

  • Warning: array_flip(): Can only flip STRING and INTEGER values! in EntityAPIController->load() (Zeile 219 von /docroot/sites/all/modules/contrib/entity/includes/entity.controller.inc).
  • Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (Zeile 388 von /docroot/includes/entity.inc).

After digging into it, I found out that it might be due to the configuration of my system. Since paragraphs field can have content i.e. in german language but not in english language, the previous patch adds null values to the array and that's the cause fo the errors.

So here's the patch that includes a check whether a value is actually set before adding it to the $paragraphs_ids array.

Status: Needs review » Needs work

The last submitted patch, 4: linkchecker-support_paragraphs-2546090-4.patch, failed testing. View results

Rudi Teschner’s picture

Rudi Teschner CreditAttribution: Rudi Teschner commented
FileSize
linkchecker-support_paragraphs-2546090-5.patch2.08 KB
pvasener’s picture

pvasener CreditAttribution: pvasener commented

https://www.drupal.org/files/issues/linkchecker-support_paragraphs-25460...

Works great on two sites using Paragraphs intensively. Thanks!

vinmassaro’s picture

vinmassaro CreditAttribution: vinmassaro commented
Status: Needs work » Needs review
vinmassaro’s picture

vinmassaro CreditAttribution: vinmassaro commented
Status: Needs review » Reviewed & tested by the community

#6 working well, thanks!

bburg’s picture

bburg
he/him
Location Washington D.C.
CreditAttribution: bburg at Forum One commented

Does the D8 version support paragraphs?

mkindred’s picture

mkindred CreditAttribution: mkindred commented
FileSize
linkchecker-support-paragraphs-2546090-11.patch1.6 KB
interdiff_5-11.txt2.01 KB

#6 works for me, as well. I fixed a few whitespace issues.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: eiriksm at Ny Media AS, Violinist, Foreningen Drupal Norge commented
Status: Reviewed & tested by the community » Needs review

Would love to see a test for this. Are you able to write a test for this, do you think?

mkindred’s picture

mkindred CreditAttribution: mkindred commented

I've never written tests. I did delve into the simpletest tutorial yesterday, and if I get far enough with it, I'll give a go.