Hello,

I get a WSOD after attempting to install either the 2.14 or 7.x-2.x-dev versions. My database is SQL Server, and this is the following error I recieve:

PDOException: SQLSTATE[42000]: [Microsoft][ODBC Driver 11 for SQL Server][SQL Server]'GROUP_CONCAT' is not a recognized aggregate function.: /* Query called from advagg_bundler_analysis() */ SELECT af.[filename] AS [filename], af.[filesize] AS [filesize], af.[mtime] AS [mtime], af.[changes] AS [changes], af.[linecount] AS [linecount], af.[filename_hash] AS [filename_hash], aa.[counter] AS [counter], aa.[hashlist] AS [hashlist] FROM {advagg_files} af INNER JOIN (SELECT aa.[filename_hash] AS [filename_hash], RIGHT(REPLICATE('0',8) + CAST(COUNT(aav.aggregate_filenames_hash) AS char(8)),8) AS counter, GROUP_CONCAT(DISTINCT aa.aggregate_filenames_hash) AS hashlist, aa.aggregate_filenames_hash AS _field_0, aa.filename_hash AS _field_1 FROM {advagg_aggregates} aa INNER JOIN {advagg_aggregates_versions} aav ON aav.aggregate_filenames_hash=aa.aggregate_filenames_hash AND aav.root=1 AND aav.atime > 1437542428 GROUP BY aa.filename_hash) aa ON af.filename_hash=aa.filename_hash; Array ( ) in advagg_bundler_analysis() (line 266 of

This is a rather big issue for us, as it forces us to restore an older version of our database before the site works again.

CommentFileSizeAuthor
#5 advagg-2545786-5-catch-pdo-bundler.patch16.29 KBmikeytown2

Comments

andrewcraswell created an issue. See original summary.

mikeytown2’s picture

mikeytown2 commented

Related issue #2510972: MS SQL: advagg_bundler_analysis is too slow and can be faster. Needs an index & use GROUP_CONCAT if available.

andrewcraswell’s picture

andrewcraswell commented

Not sure if we're allowed to do this, but I'll put a bounty of a case of beer to get this resolved by Friday (our code complete date). If you can resolve the task and also email the modified files, I'd be happy to Paypal or Venmo reimbursement. I'd implement a fix myself if I wasn't overloaded on other dev tasks lol

mikeytown2’s picture

mikeytown2 commented

This is what I run to see if GROUP_CONCAT is available; code came from the related issue

      $schema = Database::getConnection()->schema();
      $mssql_group_concat = method_exists($schema, 'functionExists') && $schema->functionExists('GROUP_CONCAT');

Are you using the latest version of https://www.drupal.org/project/sqlsrv ?

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new advagg-2545786-5-catch-pdo-bundler.patch16.29 KB

Created a patch that will turn off these SQL function calls. Noted that the bundler will run around 5x slower without GROUP_CONCAT support.

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Fixed

Commited this. Due to lack of feedback, assuming this fixed the reported issue.

  • mikeytown2 committed 7bde02c on 7.x-2.x 
    Issue #2545786 by mikeytown2: SQL Server | WSOD after installing Advagg...
andrewcraswell’s picture

andrewcraswell commented

Apologies for lack of feedback. You were indeed correct, I believe the issue is that our sqlsrv module was one major version behind. I plan to update and test again, but other project tasks have taken priority. Thanks for the quick help, PM me a paypal or venmo + cost of beer so I can reimburse you for time :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.