We need to give users the option to display the main menu as a themed Foundation Top Bar. This should be modeled after 7.x-5.x as closely as possible.

CommentFileSizeAuthor
#1 zurb_foundation-d8topbar-2545582-1.patch9.61 KBsamuel.mortenson

Comments

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new zurb_foundation-d8topbar-2545582-1.patch9.61 KB

Here's a first-attempt patch at adding the top bar back in. Right now, if topbar is enabled, anywhere you place the Main Menu block or Main menu will be rendered as with the appropriate topbar config from Drupal 7.

The main differences from Drupal 7 are:

  1. We don't force the main menu to be rendered in the page template.
  2. Only the main menu is rendered with top bar styling (no alt menus, secondary menus, etc.)

I like these changes, as this theme has always been pretty minimalistic and the less we force people to do, the better. Ideally, you could enable top bar for multiple menus, but that will probably take another issue and patch.

I'm putting this in review to see if anyone has input. If not, I'll be committing it this or next week.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Needs review » Fixed

Committed the patch with changes to fix settings and the sticky option.

  • samuel.mortenson committed 6ff751f on 8.x-5.x 
    Issue #2545582 by samuel.mortenson: Re-implement the Top Bar in 8.x-5.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.