CKEditor 4.5.2 seems to not work

Seems like the trouble is caused by this fix:
http://dev.ckeditor.com/ticket/13397

As it fails on
if ( widgetsRepo._.draggedWidget.wrapper.contains( el ) ) {
in ckeditor/plugins/widget/plugin.js on line 2421

Seems like the fix would be to add

		// Mark dragged widget for repository#finder.
		this.repository._.draggedWidget = this;

just before our greedySearch call.
However we do not use this.repository, so first would need to get the repository.
The docs claim that

An instance of the repository is available under the CKEDITOR.editor.widgets property.

Yet i cannot find it there, and neither in the editor variable existing in the scope.

Seems like
editor.widgets._.draggedWidget
Will work instead of this.repository._.draggedWidget

However the = this part not sure yet how to replace.

It needs something that it can do contains on
"Uncaught TypeError: Cannot read property 'contains' of undefined"

I got to the same conclusion.

Here is a lightweight dirty workaround for the same thing.

Seems to be working in firefox, chrome and ie 9, although more testing is always welcome.

Thanks gifad!

However I think It needs to be refactored cause now there are duplicate code when creating the widget in both the insertNewWidget function and separately when creating the dummy widget. Also snapshot should be included the same way as we have in the insertNewWidget function.
So the code would change quite a lot at the end. So maybe its better to have a more lightweight solution for now, and then later if we want to refactor the whole system, we can still do so.

@jcisio which one do you prefer? (comment #5 vs comment #6)

Thanks!

I however started a new patch because I think we can create the widget before calling the onLibraryAtomDrag and we can even pass the widget as 'this' to the function just like the code it was derived from. So this would make the code a lot more similar to the original, and maybe reduce some future problems.

Needs a bit more testing, and maybe it could be simplified even more, for now only the editor could be removed from onLibraryAtomDrag as widget.editor works fine.

Patch #9 passes my tests under chrome, firefox, and ie9, under ckeditor 4.5.2, 4.5.1, and 4.4.6

Seems like you have not tested your code, as in javascript you cannot set a default value to a function parameter, that produces an error.

Also It seems that destroying those values are not really necessary. Because the widget variable will be destroyed after the scope of the dragstart ends. And anyways there is a different widget variable per editor.

Also the draggedWidget will have a value on dragstart right away (per editor again) so setting it to null seems unnecessary, of course maybe it frees up a tiny amount of memory space.

So I think i will commit #9

So something like this.

However I get under IE 9 SCRIPT5007: Unable to get value of the property 'find': object is null or undefined
ckeditor.js: line 1129 character 190

Unfortunately that seems to make no difference.

Moved this to a followup, so we can close this issue.
#2546712: followup: ckeditor 4.5.2 compatibility - cleanup widget variable

Good news, 4.5.3 seems to work fine as well.