Allow custom input types for textfields (HTML5 input types)

If user wants to add "text" field then $element['#attributes']['type'] = 'text'; should be text and it is working fine.

Rightly noticed, Drupal 7 does not regards 'type' attribute of 'textfield' element and hence there must be some solution for this. The above patch does not works for me.

The patch seems to work for me... @purushotam.rai, if possible, could you please provide more explanation or examle of "Drupal 7 does not regards 'type' attribute of 'textfield' element and hence there must be some solution for this. The above patch does not works for me."?

@purushotam.rai : what's the code you used to test this out? could you share?

@hgoto : likewise, for you it works, can you share a code extract (or whole function) to demo in what use case it works for you?

Having the same need and would love to see progress on this and see the patch committed if validated.

Hi @littletiger,

Here goes my patch to solve this issue. It basically respects the type attribute provided using form api for textfield.

Thanks

Hi,
Please find the updated patch.

@pashupathi

Could you please provide the interdiff.

The patch #11 uses bracket syntax for the array, and it seems to be the only difference from the patch #6. I don't understand why this is necessary. The patch #6 is proper one.

This will not work properly with text fields because #type is already set to textfield in $variables['element']. (Hence all the tests failing)
What we could do is define something like a #subtype in which we should allow people to add a few already not existing types.

• number
• email
• password
• color
• url
• tel

Added a fresh patch which should not break the existing tests.

Seems there is 1 failure (still better than 973 failures) but it has to do with the max length of a "Menu link title" field.

To be investigated.

The failure was very silly. The test doesn't expect maxlength to the the last value in the HTML element. (It expects a space behind it)
I could fix it by just reordering some assignments.

This code will work by defining a #subtype when creating a form element:

$form['number_field'] = array(
'#type' => 'textfield',
'#subtype' => 'number',
'#title' => t('Number field'),
'#default_value' => 1,
'#size' => 5,
'#maxlength' => 5,
);

Tested & looks good to me.

#20 worked great for us.

We changed the quantity field in commerce to type=number.
It feels a lot better to use as a potential customer now.

With the patch in #20, created a custom module and put the following in the mymodule.module file:

function mymodule_form_alter(&$form, &$form_state, $form_id){
 if (isset($form['quantity'])){
    $form['quantity']['#subtype'] = 'number';
  }
}

Sets the quantity input type to number.
We did the condition on existence of field, not form-id as we have multiple add-to-cart forms. Trying to target by form id would be a nightmare.

Note that the patch file name allow-custom-input-types-12773594-19.patch cites the wrong issue number; it should be 2545318 not 12773594.

Changed the patch name and also added min and max attributes options.

Thanks for the report and patches. I think this is not a bug, but a feature request - D7 currently does not support HTML5 input types. This functionality can be achieved by several ways:

- contrib module (for example this: https://www.drupal.org/project/elements)
- theme_textfield override in your theme

Anyway, if this issue should be considered, minimally two things needs to be added: tests, change record. Thus I am switching status back to Needs work.