To help with testing http://drupal.org/project/issues/48429 I have back ported the crud file from the drupal 6 version.

CommentFileSizeAuthor
#12 cck-crudbackport.patch39.84 KBgordon
#8 cck-crudbackport.patch42.79 KBgordon
#7 cck-crudbackport.patch42.47 KBgordon
#6 cck-crudbackport.patch67.82 KBgordon
#5 cck-crudbackport.patch50.41 KBgordon
#2 cck-crudbackport.patch50.55 KBgordon
#1 cck-crudbackport.patch34.33 KBgordon
cck-crudbackport.patch33.81 KBgordon

Comments

gordon’s picture

gordon commented
StatusFileSize
new cck-crudbackport.patch34.33 KB

We have added these patches to Lonely Planets system, and we found a bug with deleteing fields.

Here is a new patch

gordon’s picture

gordon commented
StatusFileSize
new cck-crudbackport.patch50.55 KB

I have made an update to this patch, so that all the field updates use the crud file like they do in D6. I also found and fixed the problem with the creation of the tables a second time.

karens’s picture

karens commented

Could you please explain what bugs you found and fixed?

gordon’s picture

gordon commented

The bug that I found was actually in the crud file in that when a new instance of a field was found it would try and create the table a second time.

gordon’s picture

gordon commented
StatusFileSize
new cck-crudbackport.patch50.41 KB

Ok, I found some more problems with the system trying to alter tables twice. I think this is complete now. However there is a couple of failed tests which I am going cross eyed looking at.

gordon’s picture

gordon commented
StatusFileSize
new cck-crudbackport.patch67.82 KB

I have found the last bug in the crud file and it is now passing *all* the tests that have been backported from Drupal 6.

gordon’s picture

gordon commented
StatusFileSize
new cck-crudbackport.patch42.47 KB

Oops, I added additional changes that were already committed.

gordon’s picture

gordon commented
StatusFileSize
new cck-crudbackport.patch42.79 KB

I found a bug with one of the tables which caused some fields not to save data.

yched’s picture

yched commented

Gordon, many thanks for your work on this. We're not forgetting it, but we're currently focusing on a D6 RC for now.
Just a quick note to make sure you saw that D6 CRUD API commit : http://drupal.org/cvs?commit=123933

gordon’s picture

gordon commented

No Problem, Just for me at LP, we just can't use D6 yet maybe after the new year we will be able to upgrade, but until then we need CCK to be at it's best.

And these patches I believe that it will make CCK last until D5's end of life.

Anonymous’s picture

Anonymous (not verified) commented

Does the 2008-07-25 5.x freeze mean this feature will not make it in?

gordon’s picture

gordon commented
StatusFileSize
new cck-crudbackport.patch39.84 KB

Here is an update for the new version of CCK

karens’s picture

karens commented
Status: Needs review » Closed (won't fix)

Too old now, way past the time when we will add features to D5 version.