Problem/Motivation

When indexing and displaying comments on a node the search result and index will include admin text like "Log in" or "Delete".

Steps to reproduce

Install Standard
Create an Article
Add several comments
Search for a keyword that appears in the article

Proposed resolution

Do not render operations in CommentHooks::nodeUpdateIndex().

Remaining tasks

  • Patch
  • Review
  • Commit

User interface changes

None

API changes

None

Data model changes

None, although it could be argued that we should cause a re-index of all node's. However I think we should just let that occur naturally.

CommentFileSizeAuthor
#17 comment-searching.png89.3 KBmerilainen
#12 comment_node_update_index_includes_login_delete_edit_operations-2544516-12.patch6.35 KBwuinfo - bill wu
#7 comment_node_update_index_includes_login_delete_edit_operations-2544516-7.test.patch3.26 KBwuinfo - bill wu
#6 comment_node_update_index_includes_login_delete_edit_operations-2544516-6.patch3.09 KBwuinfo - bill wu
#5 comment_node_update_index_includes_login_delete_edit_operations-2544516-5.patch3.05 KBwuinfo - bill wu
Screen Shot 2015-08-03 at 09.38.42.png32.33 KBalexpott

Issue fork drupal-2544516

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
Issue tags: +Needs tests
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

I think that there might already be an issue for this, will go digging

wuinfo - bill wu’s picture

wuinfo - bill wu commented

Thanks, @larowlan,

Similar issue here: Comment module renders "reply" and other links in search index/results

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Related issues: +#1113832: [PP-1] Comment module renders "reply" and other links in search index/results
wuinfo - bill wu’s picture

wuinfo - bill wu commented
StatusFileSize
new comment_node_update_index_includes_login_delete_edit_operations-2544516-5.patch3.05 KB

Here is the patch for it. I added new comment displays which was suggested here: Comment module renders "reply" and other links in search index/results

wuinfo - bill wu’s picture

wuinfo - bill wu commented
StatusFileSize
new comment_node_update_index_includes_login_delete_edit_operations-2544516-6.patch3.09 KB

Fixed the exception in previous patch.

wuinfo - bill wu’s picture

wuinfo - bill wu commented
StatusFileSize
new comment_node_update_index_includes_login_delete_edit_operations-2544516-7.test.patch3.26 KB

Here is the test patch.

wuinfo - bill wu’s picture

wuinfo - bill wu commented
Status: Active » Needs review
wuinfo - bill wu’s picture

wuinfo - bill wu commented
Issue tags: -Needs tests

The last submitted patch, 5: comment_node_update_index_includes_login_delete_edit_operations-2544516-5.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 7: comment_node_update_index_includes_login_delete_edit_operations-2544516-7.test.patch, failed testing.

wuinfo - bill wu’s picture

wuinfo - bill wu commented
StatusFileSize
new comment_node_update_index_includes_login_delete_edit_operations-2544516-12.patch6.35 KB

Patch together with the test and fix.

wuinfo - bill wu’s picture

wuinfo - bill wu commented
Status: Needs work » Needs review

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

merilainen’s picture

merilainen commented
Status: Needs review » Needs work
StatusFileSize
new comment-searching.png89.3 KB

I applied the patch, re-indexed content, ran cron and cleared caches. There is still extra text visible for both anonymous and admin users, see the attached file. Admins see "Delete Edit Reply" text and anonymous users see "Login or register to post".

Edit: This works if I disable and enable the comment module, or import the new configuration with config_devel. But this should happen automatically so that sites which have comment module enabled will get the new configuration into active storage. Maybe in an update hook?

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 8.5.x-dev » 8.6.x-dev

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

acbramley’s picture

acbramley commented
Title: comment_node_update_index() includes login or delete and edit operations » CommentHooks::nodeUpdateIndex() includes login or delete and edit operations
Issue summary: View changes
Issue tags: +Bug Smash Initiative, +Needs reroll

Looks like this is still reproducible on HEAD, only for administrators though.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

rpayanm made their first commit to this issue’s fork.

rpayanm opened merge request !13653

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.