[D7] Disable Node View Full

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxNixou2544164git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Nixou,
Manual Review

I having setup for Default 404 (not found) page(admin/config/system/site-information). By sample I have mentioned node/1.
When I browse the disable content type from your module, my default error page appear twice. The fix for this issue is put exit() after drupal_not_found();

function disable_node_view_full_node_view($node, $view_mode, $langcode) {
  // Return a 404 page for choosen node type.
  if ($view_mode == 'full') {
    $type = $node->type;
    if (variable_get('disablenodeviewfull_' . $type, 0)) {
      drupal_not_found();
      exit();
    }
  }
}

I have installed your module and verified for Article Content Type. Your code has bug. It displays Page not found first and below it displays the normal drupal page.
Refer the attached video.

You can add below fix.
if (variable_get('disablenodeviewfull_' . $type, 0)) {
drupal_not_found();
drupal_exit();
}

Everything is working for me, and the code is as clean as can be.

Automatic Review

Pareview code review: http://pareview.sh/pareview/httpgitdrupalorgsandboxnixou2544164git

Manual Review

Individual user account
Yes: Follows.

No duplication
No: This module expands Views functionality.

Master Branch
Yes: Follows

Licensing
No: Add Liscense

README.txt/README.md
Yes: Follows

Code long/complex enough for review
Yes: Follows.

Secure code
Yes: Meets the security requirements.

Hi Nixou,
You are right. A project should not contain LICENSE.txt by default. It is later on added when the project gets full-project application.
Very neat and clean code.
But I have an issue.
Sending you the links to two images.
1. http://snag.gy/NDiON.jpg which shows 404 error as desired by your module. Well and fine.
However, when I promote the content to front page, the entire content is displayed. See this http://snag.gy/sv1c1.jpg
According to me, this should also return 404..
Not setting it to "Needs Work", as I am not sure whether its a bug, or you intend to show it in this way. Please comment and if required, make the changes.
Else, the module is ready for RTBC.

Hi Nixou,
Your module is too small to promote it to full project and provide the git access. Please visit Rules for not promoting to full project for more information.

Also there is not much functionality available in the module for promoting it to full project as its achieved/ can be achieved by implementing couple of Drupal Core Hooks.

So closing the issue now. If you still want your project to be reviewed further, you can re-open the issue and tag the issue with the "PAReview: Single project promote".

Thanks for your contribution!!

Small modules are perfectly fine for approval, please don't close such issues.

Duplicate module check: could you compare this with Rabbithole module please?