The documentation needs to be updated to match the functionality present in 1.0.

CommentFileSizeAuthor
#5 imagecache_token-n2544084-5.patch5 KBDamienMcKenna
#5 imagecache_token-n2544084-5.interdiff.txt6.39 KBDamienMcKenna
#4 Update_documentation-2544084-4.patch4.72 KBChris Matthews
#2 Update_documentation-2544084-2.patch0 bytesChris Matthews
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Assigned: Unassigned » Chris Matthews

Per issue #2374835: Plan for Imagecache Token v7.x-1.0 release, this issue is the last "blocker" before a full 7.x-1.0 release. I should be able to get to it in the next few days.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Assigned: Chris Matthews » Unassigned
Status: Active » Needs review
FileSize
Update_documentation-2544084-2.patch0 bytes

Here is the patch.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work

The patch is zero bytes, I suspect you forgot to do "git diff HEAD" instead of "git diff". Don't worry, everyone does that at least once a month :)

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Status: Needs work » Needs review
FileSize
Update_documentation-2544084-4.patch4.72 KB

Ah, thanks Damien. Here it is again.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
imagecache_token-n2544084-5.interdiff.txt6.39 KB
imagecache_token-n2544084-5.patch5 KB

I made some additional changes, let me know what you think.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Status: Needs review » Reviewed & tested by the community

I reviewed the changes and I think they're all right on. Sorry I missed a lot of what you included ;0 Moving to RTBC. Thanks Damien!

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks for the help, Chris!

  • DamienMcKenna committed 27cd767 on 7.x-1.x 
    Issue #2544084 by Chris Matthews, DamienMcKenna: Update documentation.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.