Hi,

I receive a notice every time I try to create Multiple choice question. It is:

Notice: Undefined index: revision in quiz_question_node_form_submit() (line 142 of sites/all/modules/contrib/quiz/question_types/quiz_question/quiz_question.module).

It is this line of code:

if ($form_state['values']['revision']) {

As far as I understood there is some issues with quiz and revisions so I decided to go with the quick and obvious fix to put the $form_state['values']['revision'] into isset().

Patch in the comment below.

Regards,
Lachezar

CommentFileSizeAuthor
#1 quiz-undefined_index_revision-2541178-1.patch1.09 KBlachezar.valchev
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lachezar.valchev’s picture

lachezar.valchev CreditAttribution: lachezar.valchev at FFW commented
Status: Needs work » Needs review
FileSize
quiz-undefined_index_revision-2541178-1.patch1.09 KB

Hi,

Patch is attached.

Regards,
Lachezar

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs review » Fixed

Thanks!

I changed isset() to !empty() because value of "revision" could possibly be set to 0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.