Flagging save throws PDO exceptions when flag has fields

Hi,

I tried to debug and found that this happens only if the node is already flagged. i.e. The user has already flagged the content and we try to flag it again using flagging_save.

I checked in code and found that incase the flag already exist then the code invokes flagging_update and in case of new flag it invokes flagging_insert functions.

flagging_update invokes field_attach_presave('flagging', $flagging);

Here the flagging don't have flagging_id set so the entity_id goes as null and the field update/insert fails.

Have fixed it in attached patch.

Thanks,
Sadashiv.

Hi,

I don't know whether the flag exist or not so I am trying to create a new flagging so am calling flagging_save without flagging id.

I think the check is already made by the flag function in include/flag/flag_flag.inc file before flagging. So if the flag exists it's calling flagging_update else it call flagging_insert.

When it calls flagging_update it is the modules responsibility to pass the existing_flagging_id and that's what I did in the code.

Steps to replicate this issue.

1) Create a node flag (flag is for page bundle).
2) Create any field for the flag
3) Create a page
4) Flag as the logged in user
5) Now may be some custom module or some import script based on a logic is flagging users where it tries to create a new flagging with the code as

  $values = array(
    'fid' => 1,
    'entity_type' => 'node',
    'entity_id' => NODE_ID,
    'uid' => USER_ID,
    'flag_name' => 'subscribe_og',
  );
  $flagging = flagging_create($values);

  flagging_save($flagging);

If we don't have fields it works fine.

Hth,
Sadashiv

Hi,

I am setting flag_name and that's not the problem. The only problem was that I was not checking whether the flag already exists. If I check that it already exists and set the flagging_id then it works. I still think that the flag module can improve some part of it or we can remove some code checking the existing flag.

Thanks,
Sadashiv.

Actually I am using message_subscribe module and as I am introducing it now I want all users of different groups to be subscribed to the group i.e. the group should be flagged by default if the user is a member so I wrote a simple script to load all members of all groups and flag the groups for each member.

As I am installing flag now and a user can be member of the group i.e. single entry in membership table for each user for a particular group I was not checking whether the group is flagged

Then I ran into this error for some reason the few group tried to flag twice for the same user. I checked and found that flag function in flag_flag.inc detects whether the flag exists or not and accordingly calls flagging_insert or flagging_update.

When it calls flagging_update it assumes that the flagging_id is set by the invoking function and in my case it wasn't so it gave me the error. before invoking flagging_update we can set it as we are retrieving it in existing_flag_id so thought of fixing that issue so that if some code don't check whether the content is flagged and invokes the flagging_save and the flag has a field then it won't throw any error but simple update the existing flag.

Hth,
Sadashiv.