Get Locations + Workbench Moderation = multiple maps displayed [#2540642]

The Workbench Moderation module (part of the Workbench module suite) allows for a publishing workflow for node revisions such as Draft -> Needs Review -> Published. For some reason using Workbench Moderation on a content type that also has a GetLocations field causes the map to appear twice on the page. I'm guessing it has something to do with the way Workbench Moderation alters Drupal's revision handling and the fact that GetLocations adds a row to the getlocations_field_entities table for every node revision, but that's as far as I investigated the issue before simply disabling moderation on the content type being affected. That's a "fix" but it means content goes live immediately.

Also, and I'm not sure if this is related, but I noticed that if I create a new node with a GetLocations map, edit/save it a few times to create a few revisions, and then delete the node, a bunch of orphaned rows remain in the getlocations_field_entities table for that now-nonexistent nid.

Comment	File	Size	Author
#7	interdiff.txt	1.97 KB	Dylan Donkersgoed
#7	get_locations-2540642-7.patch	2.71 KB	Dylan Donkersgoed
#6	interdiff.txt	2.13 KB	Dylan Donkersgoed
#6	get_locations-2540642-6.patch	2.54 KB	Dylan Donkersgoed
#5	get_locations-2540642-5.patch	2.34 KB	Dylan Donkersgoed

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hutch CreditAttribution: hutch commented 27 July 2015 at 17:29

I have struggled for too many hours with node_revisions. Getlocations_fields supplies the hook "hook_field_delete_revision()" as per the Field module docs but it is never called when a node is deleted, only the current revision is deleted (via "hook_field_delete()"), any others become orphaned as you have noticed. As it is the Field module that does the deleting and Getlocations_fields has no control over the deletion process other than providing the correct hooks I have to assume that it is a bug in Field module.

I am not familiar with the workbench moderation module but judging from its description it's likely that its behaviour will reflect difficulties with node revisions. Fortunately most of the developers I have worked with have not used it at all, too unreliable.

Comment #2

Dim CreditAttribution: Dim commented 27 October 2015 at 08:58

"I am not familiar with the workbench moderation module but judging from its description it's likely that its behaviour will reflect difficulties with node revisions. Fortunately most of the developers I have worked with have not used it at all, too unreliable."

But sometimes, we don't have the choice...
And indeed, workbench + get location = two maps (or two coordinates if we show all markers on one map). And that's not related to the orphaned rows.

Comment #3

bencontra CreditAttribution: bencontra commented 2 November 2015 at 23:15

I have this same issue. I can't find a better module for moderation than workbench moderation, but if creating duplicate rows in the getlocations_fields and entities tables is causing me no end of trouble. Any help would be much appreciated.

Comment #4

robgi CreditAttribution: robgi as a volunteer commented 27 November 2015 at 16:32

Even without the module workbench there are many orphaned records how many times the node is reviewed. It may include a patch to remove these orphaned records? Thanks (I translated with google sorry)

Comment #5

Dylan Donkersgoed CreditAttribution: Dylan Donkersgoed at Northern Commerce commented 17 June 2016 at 16:03

File	Size
get_locations-2540642-5.patch	2.34 KB

We encountered the same issue. I've attached a patch. It's a bit of a hack - doesn't address the core problem. But it should filter out duplicates when inserting or updating nodes with getlocations fields when workbench is enabled.

Comment #6

Dylan Donkersgoed CreditAttribution: Dylan Donkersgoed at Northern Commerce commented 23 June 2016 at 13:39

File	Size
get_locations-2540642-6.patch	2.54 KB
interdiff.txt	2.13 KB

Attached an improved version of the patch - the last one would cause issues with other entities. The patch now only applies to nodes and should be easier to expand to other entities if necessary (though I don't think it should be).