Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Thanks to @webflo at #2429617-233: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!), I was told to update core/composer.json
's replace
section. I had no idea that was necessary.
Proposed resolution
Prevent this by having a test.
Remaining tasks
Write test.
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#13 | add_test_to_ensure-followup-2539682-13.patch | 637 bytes | neclimdul |
#9 | add_test_to_ensure-2539682-9.patch | 1.15 KB | borisson_ |
#9 | interdiff.txt | 1.09 KB | borisson_ |
#8 | add_test_to_ensure-2539682-8.patch | 1.05 KB | borisson_ |
#8 | interdiff.txt | 2.46 KB | borisson_ |
Comments
Comment #1
borisson_Added a webtest to see test this. This couldn't go in a unit test because
system_rebuild_module_data
needs a container.Comment #2
Wim LeersGreat, thanks! :)
I've only got nits.
Verify all modules are listed in the 'replace' section of core's composer.json.
s/false/FALSE/
Comment #3
aspilicious CreditAttribution: aspilicious commentedWhat happens when you installed a contrib module? Will the test fail?
Comment #4
dawehnerLet's fix the doc
What about just scanning /core/modules ?
Comment #5
borisson_Fixed the issues from #2 and #4.
Now we're just scanning /core/modules, this also addresses @aspilicious' concern about contrib modules.
Comment #6
aspilicious CreditAttribution: aspilicious commentedSo we don't need a webtest anymore?
Comment #7
borisson_You're right, I can integrate this in the already existing unit test, let's do that.
Comment #8
borisson_This is now a part of the already existing
ComposerIntegrationTest
.Comment #9
borisson_I added some extra comments in the test.
Comment #10
Wim LeersLooks great.
Comment #11
alexpottMore tests++
Committed 151da1a and pushed to 8.0.x. Thanks!
Comment #13
neclimdulA good reason to re-enable #2105583: Add some sane strictness to phpunit tests to catch risky tests. This test doesn't assert anything. @see patch for why.
Comment #14
Mile23Fixed as a duplicate here: #2597644: ComposerIntegrationTest::testAllModulesReplaced() doesn't test anything.