Problem/Motivation

Token API has been updated to consider cacheability metadata.
The change record for more information: Token replacement needs to consider cacheability metadata

Proposed resolution

Update flag_tokens() with the API changes.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 update_flag_with_token-2539266-3-interdiff.txt529 bytesmbovan
#3 update_flag_with_token-2539266-3.patch632 bytesmbovan
#2 update_flag_with_token-2539266-2.patch652 bytesmbovan

Comments

martin107’s picture

martin107 commented

when you say

Update flag_tokens() with the API changes.

Did you have something else in mind.... flag_tokens() is commented out code at the moment?

mbovan’s picture

mbovan commented
Status: Active » Needs review
StatusFileSize
new update_flag_with_token-2539266-2.patch652 bytes

Re #1: Yes, so just providing a method-param-fix patch. :)

mbovan’s picture

mbovan commented
StatusFileSize
new update_flag_with_token-2539266-3.patch632 bytes
new update_flag_with_token-2539266-3-interdiff.txt529 bytes

Removed set for optional parameters.

socketwench’s picture

socketwench commented
Status: Needs review » Reviewed & tested by the community

Seems like an easy fix.

joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Fixed

Thanks for taking care of this. Committed.

  • joachim committed 267abf6 on 8.x-4.x authored by mbovan 
    Issue #2539266 by mbovan: Updated for change in function signature of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.