Problem/Motivation

Token API has been updated to consider cacheability metadata.
More info in the change record Token replacement needs to consider cacheability metadata

Proposed resolution

Update currency_tokens() with the API changes.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 update_currency_with-2539254-3-interdiff.txt1.45 KBmbovan
#3 update_currency_with-2539254-3.patch1.56 KBmbovan
#2 update_currency_with-2539254-2.patch713 bytesmbovan

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Would you be able to write a patch?

mbovan’s picture

mbovan commented
Status: Active » Needs review
StatusFileSize
new update_currency_with-2539254-2.patch713 bytes

Providing a patch.
Added $bubbleable_metadata in currency_tokens().

mbovan’s picture

mbovan commented
StatusFileSize
new update_currency_with-2539254-3.patch1.56 KB
new update_currency_with-2539254-3-interdiff.txt1.45 KB

- Cached loaded currency code
- Fixed code style
- Removed set for optional parameters, as they are always present.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Thanks!

  • Xano committed f526664 on 8.x-3.x authored by mbovan 
    Issue #2539254 by mbovan: Update Currency with Token changes
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.