Add/edit node form settings are misleading [#2537898]

The protected node configuration available on the node edit page is confusing for the following reasons:

When the content type is set to "Always protected", the help text on the node edit form still indicates that a checkbox is available when it actually isn't.
The "Show Title" checkbox only matters when the default description text is used. It has no effect when a custom description text is set.

Comment	File	Size	Author
#3	protected_node-node_edit_settings-2537898-3.patch	6.87 KB	digitgopher
#3	7.x-1.x: PHP 5.5 & MySQL 5.5 CI error
#1	protected_node-node_edit_settings-2537898-1.patch	3.08 KB	digitgopher
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

digitgopher CreditAttribution: digitgopher at Pacific Northwest National Laboratory commented 22 July 2015 at 16:54

Status:

Active

» Needs review

File	Size
protected_node-node_edit_settings-2537898-1.patch	3.08 KB

Resolution:
1. Move the description text to the checkbox it is for.
2. Hide the show title option if other text will be displayed regardless.

I thought about other permissions checks or text to display when the checkbox is hidden, but didn't think we needed anything else. What do you think?

As always, please let me know if I did anything wrong! Thanks.

Comment #2

22 July 2015 at 16:56

Status:

Needs review

» Needs work

The last submitted patch, 1: protected_node-node_edit_settings-2537898-1.patch, failed testing.

Comment #3

digitgopher CreditAttribution: digitgopher at Pacific Northwest National Laboratory commented 22 July 2015 at 18:30

Status:

Needs work

» Needs review

File	Size
protected_node-node_edit_settings-2537898-3.patch	6.87 KB
7.x-1.x: PHP 5.5 & MySQL 5.5 CI error

Well clearly I didn't test that. Let's try this again.

Comment #4

22 July 2015 at 18:36

Status:

Needs review

» Needs work

The last submitted patch, 3: protected_node-node_edit_settings-2537898-3.patch, failed testing.

Comment #5

digitgopher CreditAttribution: digitgopher at Pacific Northwest National Laboratory commented 22 July 2015 at 18:46

Nice, it works now.

Comment #6

22 July 2015 at 20:27

Status:

Needs work

» Needs review

digitgopher queued 3: protected_node-node_edit_settings-2537898-3.patch for re-testing.

Comment #7

digitgopher CreditAttribution: digitgopher at Pacific Northwest National Laboratory commented 22 July 2015 at 20:28

Re-testing after #2534644: fix tests for bulk actions feature marked as fixed...

Comment #8

22 July 2015 at 20:29

Status:

Needs review

» Needs work

The last submitted patch, 3: protected_node-node_edit_settings-2537898-3.patch, failed testing.

Comment #9

digitgopher CreditAttribution: digitgopher at Pacific Northwest National Laboratory commented 22 July 2015 at 20:33

My mistake, it fails concerning #2447913: Fix fork feature, fork rather than bulk. Anyway, I will wait for a review now.

Comment #10

2 August 2015 at 21:23

Grimreaper committed aabf957 on 7.x-1.x authored by digitgopher

Issue #2537898 by digitgopher, Grimreaper: Add/edit node form settings...

Comment #11

Grimreaper

French

France 🇫🇷

CreditAttribution: Grimreaper as a volunteer commented 2 August 2015 at 21:25

Status:

Needs work

» Fixed

Hello,

This is merged now. Thanks.

Notices:
- inline comments and phpdoc comments should not have more than 80 characters on the same line
- don't forget space before parenthesis in "if () {"
- variable names should not be in camelcase (in D7)