Problem/Motivation

While editing a Search Page, the path field is not required. If left empty, that can lead two problems:

  • if an other search page is defined as default, that one never be accessed as its path is redirected to the default search page
  • if that search page is defined as default, that leads to an infinite redirection loop

Steps to reproduce

  1. Install drupal with the standard profile
  2. Go to the search admin interface (admin/config/search/pages)
  3. Edit the "content" search page (admin/config/search/pages/manage/node_search)
  4. Empty the path field and save
  5. Go to /search

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because that can lead to an infinite redirection
Issue priority Normal because it only happens in a precise case
Prioritized changes The main goal of this issue is usability
Disruption Not disruptive as the default pages already have a path and having no path make that search page unusable (at least)

Proposed resolution

Make the path field required.

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions Done
Manually test the patch Novice Instructions
Add steps to reproduce the issue Novice Instructions Done
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions

User interface changes

The path field is now required.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#1 infinite_redirection_search_path-2537600-1.patch566 bytesduaelfr

Comments

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Assigned: duaelfr » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new infinite_redirection_search_path-2537600-1.patch566 bytes
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Issue summary: View changes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

This is totally reasonable. Thanks for finding, reporting, and fixing this bug!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 09e6347 and pushed to 8.0.x. Thanks!

  • alexpott committed 09e6347 on 8.0.x 
    Issue #2537600 by DuaelFr: An empty path on search pages settings leads...
cilefen’s picture

cilefen commented
Title: An empty path on search pages settings leads to an infinit redirection loop » An empty path on search pages settings leads to an infinite redirection loop

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.