Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
While editing a Search Page, the path field is not required. If left empty, that can lead two problems:
- if an other search page is defined as default, that one never be accessed as its path is redirected to the default search page
- if that search page is defined as default, that leads to an infinite redirection loop
Steps to reproduce
- Install drupal with the standard profile
- Go to the search admin interface (admin/config/search/pages)
- Edit the "content" search page (admin/config/search/pages/manage/node_search)
- Empty the path field and save
- Go to /search
Beta phase evaluation
Issue category | Bug because that can lead to an infinite redirection |
---|---|
Issue priority | Normal because it only happens in a precise case |
Prioritized changes | The main goal of this issue is usability |
Disruption | Not disruptive as the default pages already have a path and having no path make that search page unusable (at least) |
Proposed resolution
Make the path field required.
Remaining tasks
Task | Novice task? | Contributor instructions | Complete? |
---|---|---|---|
Create a patch | Instructions | Done | |
Manually test the patch | Novice | Instructions | |
Add steps to reproduce the issue | Novice | Instructions | Done |
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions |
User interface changes
The path field is now required.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#1 | infinite_redirection_search_path-2537600-1.patch | 566 bytes | DuaelFr |
Comments
Comment #1
DuaelFrComment #2
DuaelFrComment #3
jhodgdonThis is totally reasonable. Thanks for finding, reporting, and fixing this bug!
Comment #4
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 09e6347 and pushed to 8.0.x. Thanks!
Comment #6
cilefen CreditAttribution: cilefen commented